1488026 - onAttached fired before onDetached for the last tab

Status: RESOLVED FIXED

(WebExtensions :: Frontend, enhancement)

Description

[Oriol Brufau [:Oriol]]

Run this code:

  browser.tabs.onAttached.addListener(function(...args) {
    console.log("onAttached", ...args);
  });
  browser.tabs.onDetached.addListener(function(...args) {
    console.log("onDetached", ...args);
  });

If you drag a tab between windows, you will see first an onDetached event and then the onAttached one.

However, if the dragged tab is the last one in its old window, that window will close, and onAttached will appear first.

This is not supposed to happen: https://searchfox.org/mozilla-central/rev/c8483bebfa09173b1db5590b3c19f42270d819c9/browser/components/extensions/parent/ext-browser.js#508-509

Chrome does it right.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1488026 - Always fire onDetached event before onAttached. r=mixedpuppy

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 9005909 [details]
Bug 1488026 - Always fire onDetached event before onAttached. r=mixedpuppy

Shane Caraveo (:mixedpuppy) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7bddc0708f1
Always fire onDetached event before onAttached. r=mixedpuppy

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f7bddc0708f1

Comment 5

[Vlad Jiman]

Hello, I've attempted to validate this bug using the above info, but the code shown does not seem to yield any result, could you please clarify the STR or if manual testing is not required set the “qe-verify -“ flag.

Thanks!

Comment 6

[Oriol Brufau [:Oriol]]

The output appears in the console. Covered by automated tests anyway