Closed Bug 1488114 Opened Last year Closed Last year
Refactor the reducers in RDM
No description provided.
Attachment #9006078 - Flags: review?(rcaliman) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/7ffb06278c4c Refactor the reducers in RDM. r=rcaliman
Backed out for xpcshell failures on test_change_pixel_ratio.js. Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=197401509&repo=mozilla-inbound&lineNumber=2110
Backout by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/64c4f4204676 Backed out changeset 7ffb06278c4c for xpcshell failures on test_change_pixel_ratio.js. CLOSED TREE
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/aba81999ef71 Refactor the reducers in RDM. r=rcaliman
I originally intended to fix it in dedicated Bug 1488566, but the patch here landed the fix already. This patch is just a subset of the patch that landed on central, which is actually not related to the rest of the refactor done in this patch. Forwarding r+ received on Bug 1488566 already. This patch is rebased on top of latest Beta. Approval Request Comment [Feature/Bug causing the regression]:1467572 [User impact if declined]:Users might be unable to stop Responsive Design Mode [Is this code covered by automated tests?]:no [Has the fix been verified in Nightly?]:no [Needs manual test from QE? If yes, steps to reproduce]: yes, STRs are: STRs: - clean profile - open any website - enable Responsive Design Mode - check "Reload when user agent is changed" - change the user agent - try to stop Responsive Design Mode [List of other uplifts needed for the feature/fix]: None [Is the change risky?]:no [Why is the change risky/not risky?]: simple JS fix [String changes made/needed]:One new string responsive.reloadNotification.description2 (replaces responsive.reloadNotification.description)
Comment on attachment 9006778 [details] [diff] [review] fix_localization_error_beta.patch Simple l10n js fix, flod is OK with it, uplift accepted for 63 beta 4
Attachment #9006778 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified, that the issue is no longer reproducible with STR from Comment 8 on Nightly 64.0a1(20180907100116) and Beta 63.0b4(20180906162647). RDM is closed successfully, also the error mentioned in Bug 1488566 is not displayed in browser console.
You need to log in before you can comment on or make changes to this bug.