Closed Bug 1488122 Opened 2 years ago Closed 2 years ago

Additive animations don't reflect changes to the base value

Categories

(Core :: DOM: Animation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

Attachments

(6 files, 1 obsolete file)

Attached file Test case
In the attached case we have an additive animation. After it finishes, we change the base value. The computed style should update but it doesn't. However, if we call finish() on the already finished animation it does update.
Note that this is not specifically limited to filling animations but affects animations whose value is not changing too (e.g. step timing functions).
Attached patch WPT tests (obsolete) — Splinter Review
Here are some more thoroughgoing tests for this. Most of these tests pass. Only the four base value tests fail.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Attachment #9005950 - Attachment is obsolete: true
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/872ccfbcfe6f
Add tests for filling effects; r=hiro
https://hg.mozilla.org/integration/autoland/rev/716bbe3d3a15
Rename KeyframeEffect::mBaseStyleValuesForServo to just mBaseValues; r=hiro
https://hg.mozilla.org/integration/autoland/rev/174486c8cedb
Update additive filling animations when the base style changes; r=hiro
https://hg.mozilla.org/integration/autoland/rev/3c61fb185d51
Factor out type definition for base values hashmap; r=hiro
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14408 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Depends on: 1512678
QA Whiteboard: [good first verify]

I have reproduced this bug with Nightly 63.0a1 (2018-09-02) on Windows 7, 64 Bit! This bug's fix is verified with latest Beta 65.0b10!

Build ID 20190110221328
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

QA Whiteboard: [good first verify] → [good first verify] [testday20190111]
You need to log in before you can comment on or make changes to this bug.