1488122 - Additive animations don't reflect changes to the base value

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement, P3)

Description

[Brian Birtles (:birtles)]

Attachment: Test case

In the attached case we have an additive animation. After it finishes, we change the base value. The computed style should update but it doesn't. However, if we call finish() on the already finished animation it does update.

Comment 1

[Brian Birtles (:birtles)]

Attachment: Additional test case (animation in progress)

Note that this is not specifically limited to filling animations but affects animations whose value is not changing too (e.g. step timing functions).

Comment 2

[Brian Birtles (:birtles)]

Attachment: WPT tests

Here are some more thoroughgoing tests for this. Most of these tests pass. Only the four base value tests fail.

Comment 3

[Brian Birtles (:birtles)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=51cbeb56067279a4d1f13f8e237e43f8e990bbb3

Comment 4

[Brian Birtles (:birtles)]

Attachment: Bug 1488122 - Add tests for filling effects; r?hiro

Comment 5

[Brian Birtles (:birtles)]

Attachment: Bug 1488122 - Rename KeyframeEffect::mBaseStyleValuesForServo to just mBaseValues; r?hiro

Depends on D13932

Comment 6

[Brian Birtles (:birtles)]

Attachment: Bug 1488122 - Update additive filling animations when the base style changes; r?hiro

Depends on D13933

Comment 7

[Brian Birtles (:birtles)]

Attachment: Bug 1488122 - Factor out type definition for base values hashmap; r?hiro

Depends on D13934

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/872ccfbcfe6f
Add tests for filling effects; r=hiro
https://hg.mozilla.org/integration/autoland/rev/716bbe3d3a15
Rename KeyframeEffect::mBaseStyleValuesForServo to just mBaseValues; r=hiro
https://hg.mozilla.org/integration/autoland/rev/174486c8cedb
Update additive filling animations when the base style changes; r=hiro
https://hg.mozilla.org/integration/autoland/rev/3c61fb185d51
Factor out type definition for base values hashmap; r=hiro

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14408 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/872ccfbcfe6f
https://hg.mozilla.org/mozilla-central/rev/716bbe3d3a15
https://hg.mozilla.org/mozilla-central/rev/174486c8cedb
https://hg.mozilla.org/mozilla-central/rev/3c61fb185d51

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 13

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 63.0a1 (2018-09-02) on Windows 7, 64 Bit! This bug's fix is verified with latest Beta 65.0b10!

Build ID 20190110221328
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0