Closed Bug 1488155 Opened 2 years ago Closed 2 years ago

links sometimes not styled properly in about:privatebrowsing in a private browsing window

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: heycam, Assigned: emilio)

References

Details

(Keywords: regression)

Attachments

(2 files)

STR:

1. Open a new private browsing window.
2. Keep hitting refresh.
3. Notice that occasionally, the "See how it works" and "Private Browsing" links are colored blue, as if the :link rule did not apply.
Chances are this is a regression from bug 1477773... Private browsing disables :visited, so if the :link state is applied async that patch noops it.
Attachment #9005969 - Attachment mime type: text/plain → text/html
Attachment #9005969 - Attachment description: Testcase → Testcase (open in private window)
Blocks: 1477773
Assignee: nobody → emilio
Other changes should really be (and are) indistinguishable.
Comment on attachment 9005978 [details]
Only no-op visited <-> unvisited changes.

Cameron McCormack (:heycam) has approved the revision.
Attachment #9005978 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/3430ddb28e84
Only no-op visited <-> unvisited changes. r=heycam
https://hg.mozilla.org/mozilla-central/rev/3430ddb28e84
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment on attachment 9005978 [details]
Only no-op visited <-> unvisited changes.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1477773
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: not risky
[Why is the change risky/not risky?]: one-liner that makes us go back to previous behavior in some cases
[String changes made/needed]: none
Attachment #9005978 - Flags: approval-mozilla-beta?
Flags: in-testsuite+
Comment on attachment 9005978 [details]
Only no-op visited <-> unvisited changes.

I verified the fix on central, regression fix approved for 63 beta 4
Attachment #9005978 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.