Closed
Bug 1488227
Opened 6 years ago
Closed 6 years ago
Unhandled exceptions during OOM testing cause the shell to exit with an error
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
5.65 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
The destructor of the shell class AutoReportException sets the shell exit code to either EXITCODE_OUT_OF_MEMORY or EXITCODE_RUNTIME_ERROR on unhandled exceptions. These occurs normally during OOM testing if we simulate OOM (or related error) in a problematic place. This leads to tests that 'fail' after a successful oomTest().
|
Assignee | |
Comment 1•6 years ago
|
||
Patch to skip setting shell exit code on unhandled exception during OOM testing. This means we can remove all the expected test failures for oomTests that trigger this, mostly debugger tests. I had to fix the debug/bug1272908.js test so that it ran at all - I guess 'slow' tests don't get run too often.
Attachment #9006022 -
Flags: review?(nicolas.b.pierron)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9006022 [details] [diff] [review] bug1488227-shell-exit Review of attachment 9006022 [details] [diff] [review]: ----------------------------------------------------------------- Good catch!
Attachment #9006022 -
Flags: review?(nicolas.b.pierron) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4280f360fdb9 Don't set shell exit code during OOM testing r=nbp
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4280f360fdb9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
|
||
Updated•6 years ago
|
Target Milestone: mozilla64 → mozilla63
|
|
||
Updated•6 years ago
|
Target Milestone: mozilla63 → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•