Closed Bug 1488244 Opened 7 years ago Closed 1 year ago

It's possible to request review from someone who can't access the bug

Categories

(Conduit :: Phabricator, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1567526

People

(Reporter: jandem, Unassigned)

References

Details

(Keywords: conduit-triaged)

I just used moz-phab to request review on the patch for bug 1484905, but the reviewer (arai) wasn't able to access the bug and asked me to CC them after they got the review request. Splinter detects this situation and you have to CC the reviewer before you can request r?. It would be nice if Phabricator could do the same: the bug usually has context and discussion that's useful when reviewing the fix.
This is unfortunately probably rather tricky to fix since moz-phab doesn't talk to BMO and since the security settings generally flow from BMO to Phabricator. Maybe our syncing system could fix this automatically, although we'll have to be careful to avoid cycles.
Keywords: conduit-triaged
Whiteboard: [phabricator-backlog]
Keywords: conduit-backlog
Whiteboard: [phabricator-backlog]
Keywords: conduit-backlog
Priority: -- → P3

Is this the same as bug 1567526?

See Also: → 1567526
Status: NEW → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1567526
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.