Closed Bug 1488313 Opened 2 years ago Closed 2 years ago

Nightly valgrind testing rebuilds and clobbers index for the linux64 build job.


(Firefox Build System :: Task Configuration, defect)

Not set


(firefox68 fixed)

Tracking Status
firefox68 --- fixed


(Reporter: Callek, Assigned: tomprince)



(5 files)

In doing unrelated work [1] I found that we rebuild linux64 opt every time we do valgrind testing... 

e.g. was found for push id 34555 which corresponds to

The target tasks only show the mochitest valgrinds...

[1] -
jmaher, can you clarify our intentions for mochitest-valgrind ?

There's a valgrind-linux64-valgrind/opt job on each m-c push [1], which runs ./mach valgrind-test via a mozharness action, and sets taskcluster routes which don't interfere with the main Linux64 opt (build-linux64/opt) [2]. 

The periodic Vg cron creates a second build-linux64/opt [3], which the mochitest-valgrind tests download and use. The bug here is that the build overwrites some routes of the on-push build, including [4].  

So I'm wondering if the mochitest-valgrind tests are using the right build or no. If they are it seems like there's some task graph generation issue where the previous opt build isn't used.

aside: anyone looking on treeherder should enable tier3 to see the mochitest-valgrind tests [5]

[4] index.gecko.v2.mozilla-central.revision.8284cddccf78566ca4dc45272940ccae4b1150df.firefox.linux64-opt
Flags: needinfo?(jmaher)
If we do want to use the `build-linux64/opt for the mochitest-valgrind jobs, then we probably want to do something like rel-pro, where the valgrind-cron tasks pulls in the build-linux64-opt build from the on-push graph.
interesting observations.  Valgrind tests should be using a valgrind build.  Our goal is to keep these running regularly, but not per commit.  This is where the cronjob comes in for the build which should then kick off all the tests.

It is much nicer to schedule per-commit on mozilla-central (<10/day) instead of a cronjob.  I don't think there is enough support for doing this which means running only the crontab and the related valgrind test jobs once/day.
Flags: needinfo?(jmaher)
Assignee: nobody → mozilla

This avoids the surprising result of try_task_config.json overriding explicit
--target-tasks-method from a cron task run against a try push.

Pushed by
[taskgraph] Move some functions for interacting with existing taskgraph to a more generic location; r=aki
[taskgraph] Add options to reuse on-push tasks in cron graphs; r=dustin,aki
[taskgraph] Reuse on-push build in nightly valgrind graphs; r=dustin
Pushed by
[taskgraph] Only look for try parameters in on-push decision tasks; r=dustin
[taskgraph] Don't notify sherrifs on cron decision task failures on try; r=dustin
You need to log in before you can comment on or make changes to this bug.