1488337 - Rename mozilla::dom::SelectionChangeListener to mozilla::SelectionChangeEventDispatcher

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

SelectionChangeListener is too generic name but it just dispatches selectionchange event when it's necessary.  So, it should be renamed to SelectionChangeEventDispatcher. Additionally, it's in mozilla::dom namespace but it does not represent any DOM object. So, it should be in mozilla namespace instead.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=706b56829170520b72c49d88e2e9757d269582d8

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1488337 - Rename mozilla::dom::SelectionChangeListener to mozilla::SelectionChangeEventDispatcher

SelectionChangeListener is too generic name but it just dispatches
selectionchange event when it's necessary.  So, it should be renamed to
SelectionChangeEventDispatcher. Additionally, it's in mozilla::dom namespace
but it does not represent any DOM object. So, it should be in mozilla namespace
instead.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9006185 [details]
Bug 1488337 - Rename mozilla::dom::SelectionChangeListener to mozilla::SelectionChangeEventDispatcher

Olli Pettay [:smaug] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59b228f7faf1
Rename mozilla::dom::SelectionChangeListener to mozilla::SelectionChangeEventDispatcher r=smaug

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/59b228f7faf1