1488377 - Use target.getFront to instantiate CssPropertiesFront

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Yulia Startsev [:yulia]]

Example refactoring from front instantiation to getFront --> https://phabricator.services.mozilla.com/D4579

* CssPropertiesFront:
  https://searchfox.org/mozilla-central/search?q=CssPropertiesFront(&case=false&regexp=false&path=
  This one is interesting as if we drop the compatibility layer, we may be able to drop this intermediate piece of code that was doing memoization.

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1488377 - Use target.getFront to instantiate CssPropertiesFront; r=ochameau

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14f893f7de2d
Use target.getFront to instantiate CssPropertiesFront; r=ochameau

Comment 3

[Yulia Startsev [:yulia]]

Attachment: Bug 1488377 - remove outdated backwards compat code; r=ochameau

Depends on D7886

Comment 4

[Eliza Balazs [:ebalazs_]]

Backed out changeset 14f893f7de2d (Bug 1488377) for mochitest failures in devtools/server/tests/mochitest/test_css-properties.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception,usercancel,runnable&selectedJob=204006828&revision=14f893f7de2dac98a5690d11507cadd1f6bd0030

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=204006828&repo=autoland&lineNumber=5425

Backout push: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception,usercancel,runnable&selectedJob=204006828&revision=0e28323e25ef72bc60ce7238f982d071feb6f509

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/463f83f78a0e
Use target.getFront to instantiate CssPropertiesFront; r=ochameau

Comment 6

[Yulia Startsev [:yulia]]

Thanks for catching that, should be fixed now

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01f66f8de794
remove outdated backwards compat code; r=ochameau

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/463f83f78a0e

Comment 9

[Narcis Beleuzu [:NarcisB]]

Backed out for dt failures on browser_outputparser.js.

Push link: https://hg.mozilla.org/integration/autoland/rev/01f66f8de794aa0dec271abb129154432f4071cb
Backout link: https://hg.mozilla.org/integration/autoland/rev/8027a01f2d708dff9aeb453af35b69224b50cf1a
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=204252686&repo=autoland&lineNumber=16825

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/affa0f9b807d
remove outdated backwards compat code; r=ochameau

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/affa0f9b807d