Closed Bug 1488377 Opened Last year Closed 11 months ago

Use target.getFront to instantiate CssPropertiesFront

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: yulia, Assigned: yulia)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission)

Attachments

(2 files)

Example refactoring from front instantiation to getFront --> https://phabricator.services.mozilla.com/D4579

* CssPropertiesFront:
  https://searchfox.org/mozilla-central/search?q=CssPropertiesFront(&case=false&regexp=false&path=
  This one is interesting as if we drop the compatibility layer, we may be able to drop this intermediate piece of code that was doing memoization.
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14f893f7de2d
Use target.getFront to instantiate CssPropertiesFront; r=ochameau
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/463f83f78a0e
Use target.getFront to instantiate CssPropertiesFront; r=ochameau
Assignee: nobody → ystartsev
Thanks for catching that, should be fixed now
Flags: needinfo?(ystartsev)
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01f66f8de794
remove outdated backwards compat code; r=ochameau
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/affa0f9b807d
remove outdated backwards compat code; r=ochameau
Flags: needinfo?(ystartsev)
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/affa0f9b807d
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Whiteboard: dt-fission
You need to log in before you can comment on or make changes to this bug.