1488406 - Allow finish() to measure in seconds n addition to ms

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

At the moment we are forced to clone `devtools/client/shared/TelemetryStopwatch.jsm` so that we can get it working the way we need.

The problem is that it measure time in ms when using start() finish() etc. and that creates too many entries in our charts and makes them next to impossible to read.

It would be much better if we could measure the time in seconds instead.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1488406 - Allow finish() to measure in seconds n addition to ms

At the moment we are forced to clone `devtools/client/shared/TelemetryStopwatch.jsm` so that we can get it working the way we need.

The problem is that it measure time in ms when using start() finish() etc. and that creates too many entries in our charts and makes them next to impossible to read.

It would be much better if we could measure the time in seconds instead.

Comment 2

[Georg Fritzsche [:gfritzsche]]

I can review this, i'd just like to settle the conversation in bug 1488363 first so i understand the needs here better.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d39423ad4cce4b8076e908aa2e0262a46150594

Comment 4

[Georg Fritzsche [:gfritzsche]]

Mike, can you move the review here to janerik (jrediger)?

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=14f1ed8307cc9a56ef0a7e1e25af77b8964b2bc6

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd094f46a5eb
Allow finish() to measure in seconds n addition to ms r=janerik

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/cd094f46a5eb