Closed Bug 1488419 Opened Last year Closed Last year

Font editor: axis value replaces whole font-variation-settings declaration

Categories

(DevTools :: Inspector: Fonts, defect, P2)

defect

Tracking

(firefox63 fixed, firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: rcaliman, Assigned: rcaliman)

References

Details

Attachments

(1 file)

Steps: 
- Go to v-fonts.com
- Find the "Renner" font example and inspect the preview text in DevTools
- Switch to 3-pane mode with the Fonts panel alongside the CSS rules panel
- Drag the Italic slider in the Fonts panel

Expected:
- Both the "wdth" and the "ital" values show up in the `font-variation-settings` property on the selected element's inline styles.

Actual
- Sometimes, as you drag the slider, the "ital" axis value replaces the whole value. The behavior is inconsistent.

Suspected root cause:
Race condition between previewing the changes on the page and writing them to the CSS rule view.
Comment on attachment 9006255 [details]
Bug 1488419 - Re-attach listener for Rule view change after writing new value. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.
Attachment #9006255 - Flags: review+
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46f7c652efca
Re-attach listener for Rule view change after writing new value. r=gl
https://hg.mozilla.org/mozilla-central/rev/46f7c652efca
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment on attachment 9006255 [details]
Bug 1488419 - Re-attach listener for Rule view change after writing new value. r=gl

Approval Request Comment
[Feature/Bug causing the regression]:
https://bugzilla.mozilla.org/show_bug.cgi?id=1488419

[User impact if declined]:
While using the new Font Editor in Devtools some users can lose changes made to the `font-variation-settings` CSS property.

[Is this code covered by automated tests?]:
No. The current test infrastructure uses OS configurations which don't support variable fonts (current: OSX 10.10, needed: macOS 10.13)

[Has the fix been verified in Nightly?]:
Yes

[Needs manual test from QE? If yes, steps to reproduce]:
No
 
[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
Minimal impact on Font Editor users (subset of DevTools users) editing a variable fonts (even smaller subset of users). The patch fixes a race condition which made the issue very frequent for this subset of users.

[String changes made/needed]:
None
Attachment #9006255 - Flags: approval-mozilla-beta?
Comment on attachment 9006255 [details]
Bug 1488419 - Re-attach listener for Rule view change after writing new value. r=gl

Uplift approved for 63 beta 5
Attachment #9006255 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.