Open Bug 1488494 Opened 7 years ago Updated 7 years ago

Warn about lack of active reviewers when all reviewers resigned

Categories

(Conduit :: Phabricator, enhancement, P5)

Product:
Conduit
Component:
Phabricator
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: zbraniecki, Unassigned)

Details

(Keywords: conduit-triaged, conduit-upstream)

I had a scenario where I had to work on a patch for quite a while. I requested review at some point, and the reviewer provided a review and requested changes which took a long time to apply. In the meantime, the reviewer wanted to clean up their review queue so they "resigned" from reviewing it. When I was done, I updated the patch and the page showed that he's still the reviewer, and only a small icon "x" instead of "o" by their name indicated that they resigned. What's more, the page didn't show any warning about lack of active reviewers. The only way to re-request review we found was to remove the reviewer and then add them back in 2 separate steps. In the middle, after removing the reviewer, the page showed a clear warning note to the effect of "this patch has no reviewer". It would be great if the state in which all reviewers resigned was treated the same way as if there was no reviewer assigned at all.
Keywords: conduit-triaged
Whiteboard: [phabricator-backlog][phabricator-upstream]
Keywords: conduit-backlog, conduit-upstream
Whiteboard: [phabricator-backlog][phabricator-upstream]
Keywords: conduit-backlog
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.