Closed Bug 14885 Opened 21 years ago Closed 21 years ago

default dialog button causing window close also crashes

Categories

(SeaMonkey :: General, defect, P3, critical)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: danm.moz, Assigned: danm.moz)

Details

Open the File / Open Web Location dialog.  Type a character or more in the edit field.  Hit "return". Crash.
It looks like the handler for the key event is trying to do some post-processing using as its target a deleted frame
from the recently dismissed dialog.
  I'm looking at this one at the moment.  All rights to reassign reserved.
Status: NEW → ASSIGNED
Target Milestone: M10
Severity: major → critical
Whiteboard: problem understood. fix so far elusive.
The mFrame in nsEnderKeyListener is deleted in the HandleDOMEvent call within KeyUp,
thanks to a JavaScript event handler in the window.  Subsequent use in PostHandleEvent crashes.
The window's deletion could be survived by simply handling the bad mFrame within KeyUp.
Attempts to do this have disappointed.
Whiteboard: problem understood. fix so far elusive. → problem understood. discussing fix.
Whiteboard: problem understood. discussing fix. → controversial fix coded, not checked in.
Whiteboard: controversial fix coded, not checked in. → fix ready to check in all %!!@#$ closed tree day
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Whiteboard: fix ready to check in all %!!@#$ closed tree day
Event handler now holds a weak reference to the ephemeral frame. It knows when the frame is deleted,
and recovers. Fix checked in to trunk and M10 branch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This is still crashing on a windows M10 candidate build. Will have to
release-note. Re-opening so I'll remember to check it on the tip builds.
To reproduce just use File / Open Web Location and type in a url and press
return.
changing QA contact to cpratt
QA Contact: leger → cpratt
Target Milestone: M10 → M11
Moving to M11.  paulmac, please Release Note for M10 at:
http://bugzilla.mozilla.org/show_bug.cgi?id=14872
Status: REOPENED → RESOLVED
Closed: 21 years ago21 years ago
Resolution: --- → FIXED
Damn.  Checking source, I see I goofed hand-merging my changes into M10.
Good news is, it's still fixed in M11.  Marking fixed M11.
Status: RESOLVED → VERIFIED
the crash does not happen with M11 builds. There is still a problem, however,
that Open Web Location goes into some type of endless loop where the URL never
gets loaded. A new bug will be opened on that. Marking this bug verified.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.