[remote-dbg-next] Add validation to Connect > Add Network Location form

RESOLVED FIXED in Firefox 68

Status

enhancement
P1
normal
RESOLVED FIXED
9 months ago
2 months ago

People

(Reporter: jdescottes, Assigned: daisuke)

Tracking

(Blocks 1 bug)

Trunk
Firefox 68
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: old-remote-debugging-ng-m3)

Attachments

(2 attachments)

Reporter

Description

9 months ago
Currently our form accepts any type of input. We should do some light validation and show error messages when users type incorrect values, duplicated values etc...
Reporter

Updated

9 months ago
Priority: P5 → P3
Reporter

Updated

8 months ago
No longer blocks: remote-debugging-ng-m1
Reporter

Updated

8 months ago
Reporter

Comment 1

6 months ago
filter on remote-debugging-next-move-m3-to-m2
Reporter

Comment 2

6 months ago
filter on remote-debugging-next-move-m3-to-m2
Reporter

Comment 3

6 months ago
filter on remote-debugging-next-move-m3-to-m2
No longer blocks: remote-debugging-ng-m3
Whiteboard: old-remote-debugging-ng-m3
Priority: P3 → P2
Assignee

Updated

2 months ago
Assignee: nobody → dakatsuka
Status: NEW → ASSIGNED
Priority: P2 → P1

Comment 6

2 months ago
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4968b4484074
Validation for network location. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/1b763fdfc0ba
Add test for validation. r=jdescottes
Assignee

Comment 8

2 months ago

I'm sorry to bother you Neomi.
I'll take a look.

Flags: needinfo?(dakatsuka)

Comment 9

2 months ago
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4354c226d338
Validation for network location. r=jdescottes,flod
https://hg.mozilla.org/integration/autoland/rev/5841b4e99593
Add test for validation. r=jdescottes

Comment 10

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.