1488503 - [remote-dbg-next] Add validation to Connect > Add Network Location form

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

Currently our form accepts any type of input. We should do some light validation and show error messages when users type incorrect values, duplicated values etc...

Comment 1

[Julian Descottes [:jdescottes]]

filter on remote-debugging-next-move-m3-to-m2

Comment 2

[Julian Descottes [:jdescottes]]

filter on remote-debugging-next-move-m3-to-m2

Comment 3

[Julian Descottes [:jdescottes]]

filter on remote-debugging-next-move-m3-to-m2

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1488503: Validation for network location. r?jdescottes

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1488503: Add test for validation. r?jdescottes

Depends on D23993

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4968b4484074
Validation for network location. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/1b763fdfc0ba
Add test for validation. r=jdescottes

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1488503) for failing in browser_misused_characters_in_strings.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=7a6c0fd62287aeb4fd4e3ae086174e545f67b7bb&revision=1b763fdfc0ba121950f386e15d7b72432079835d

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=235014889&repo=autoland&lineNumber=2734

Backout: https://hg.mozilla.org/integration/autoland/rev/989c91cf970eebff42ea372951399cdfaa8ccf03

Comment 8

[Daisuke Akatsuka (:daisuke)]

I'm sorry to bother you Neomi.
I'll take a look.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4354c226d338
Validation for network location. r=jdescottes,flod
https://hg.mozilla.org/integration/autoland/rev/5841b4e99593
Add test for validation. r=jdescottes

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4354c226d338
https://hg.mozilla.org/mozilla-central/rev/5841b4e99593