1488566 - Unable to leave RDM, "No localization found for [responsive.reloadConditions.label]"

Status: RESOLVED DUPLICATE of bug 1488114

(DevTools :: Responsive Design Mode, defect, P2)

Description

[Julian Descottes [:jdescottes]]

STRs:
- clean profile
- open any website
- check "Reload when user agent is changed"
- change the user agent
- try to stop RDM

Impossible to leave RDM, user agent of the browser is messed up after restarting etc...

Browser console logs 
  Error: "No localization found for [responsive.reloadConditions.label]"

Regression from https://hg.mozilla.org/mozilla-central/rev/81d81c2f9098

Bug 1467572 part 9

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1488566 - Update reload notification message to stop using missing string;r=gl,flod

Note that the feature itself is useless in its current state,
because it displays a banner on the content page which is being reloaded.
We should pass command: true to showNotification in order to show the banner
in the toolbox (and therefore persist the message after the reload). However
this will need to wait after Bug 1429421

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

I actually fixed this in Bug 1488114 as well.

Comment 3

[Francesco Lodolo [:flod]]

Comment on attachment 9006368 [details]
Bug 1488566 - Update reload notification message to stop using missing string;r=gl,flod

Francesco Lodolo [:flod] has approved the revision.

Comment 4

[Julian Descottes [:jdescottes]]

gl: this needs an uplift to beta, are you confident we can uplift the refactor?

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9006368 [details]
Bug 1488566 - Update reload notification message to stop using missing string;r=gl,flod

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 6

[Julian Descottes [:jdescottes]]

I assumed you would pull the duplicated changes out of the other bug, now this can't land on central anymore. Let's move everything to your other bug.