Closed Bug 1488582 Opened 6 years ago Closed 6 years ago

Stop computing titlebar placeholder sizes manually in browser-tabsintitlebar.js

Categories

(Firefox :: Theme, enhancement, P5)

Product:
Firefox
Component:
Theme
Type:
enhancement

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: mconley, Unassigned)

References

Details

These widths are being calculated in browser-tabsintitlebar.js by sampling the titlebar-buttonbox and titlebar-secondary-buttonbox (which can flush layout), and manually setting the widths.

These are static widths that I think we can calculate without JS. I'm breaking this out from bug 1356920 where I hope to remove all JS layout calculations.

Here's how I'm going to break down this work:

Windows (compositor, where we draw the buttons in browser-aero.css):
* Add some build-time defines to mirror the dimensions to the placeholders

Windows (no compositor):
* Set the titlebar-placeholder[type="caption-buttons"] to -moz-appearance: -moz-window-button-box

macOS:
* Set the titlebar-placeholder[type="caption-buttons"] to -moz-appearance: -moz-window-button-box, and also set visibility: hidden
* Move the 12px margin-left hardcoded here: https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/browser/themes/osx/browser.css#116 into the macOS native theme code.

Linux:
* Add support for -moz-appearance: -moz-window-button-box, such that it returns an empty frame with the correct dimensions.
I'm skeptical that this is the right approach, see bug 1356920 comment 19.

(In reply to Mike Conley (:mconley) (:⚙️) from comment #0)
> These are static widths that I think we can calculate without JS. I'm
> breaking this out from bug 1356920 where I hope to remove all JS layout
> calculations.

I don't see how this is a meaningful step towards bug 1356920 comment 6 / bug 1356920 comment 7, which I expect is the only way to remove all JS layout code.
Priority: -- → P5
Flags: needinfo?(mconley)
Yeah, having talked this out with dao in bug 1356920, I think we've settled on a solution that'll let us drop the placeholders entirely.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(mconley)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.