Closed Bug 1488586 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 12834 - Throw errors for invalid rolloffFactor and coneOuterGain

Categories

(Core :: Web Audio, enhancement, P4)

Product:
Core
Component:
Web Audio
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12834 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/12834 Details from upstream follow. Raymond Toy <rtoy@chromium.org> wrote: > Throw errors for invalid rolloffFactor and coneOuterGain > > The WebAudio spec says we must throw errors for a negative > rolloffFactor and for a coneOuterGain outside the interval [0, > 1]. Make it so. > > Also add some additional tests to ctor-panner.html to verify that a > rolloffFactor of 0 or 100 do not throw errors and that a > coneOuterGain of 0 or 1 do not throw errors. > > Remove invalid tests from panner-rolloff-clamping.html because > negative a rolloffFactor now throws an error. > > Finally remove text expectation for ctor-panner.html test, which > passes now. > > Bug: 879845 > Test: the-pannernode-interface/ctor-panner.html, the-pannernode-interface/panner-rolloff-clamping.html > Change-Id: Ie90e9fe13e82fd3cc955060dc9e77266ef4ff591 > Reviewed-on: https://chromium-review.googlesource.com/1205099 > WPT-Export-Revision: 4aea1fbfaff11a97b36164482cf3b68f21b6598f
PR 12834 applied with additional changes from upstream: 4fd41de6ecf73b21534c81fc0f516defdca50ab1, 1ce329cb195c77b3d26cb1cadc75aecef7d33728
Component: web-platform-tests → Web Audio
Product: Testing → Core
Ran 2 tests and 36 subtests OK : 1 PASS : 33 FAIL : 3 ERROR : 1 New tests that have failures or other problems: /webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping.html # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed.: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6f551194b379 [wpt PR 12834] - Throw errors for invalid rolloffFactor and coneOuterGain, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/3ee77f25fef1 [wpt PR 12834] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/6f551194b379 https://hg.mozilla.org/mozilla-central/rev/3ee77f25fef1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.