1488590 - Add tests to mozdevice::adb.py

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement, P2)

Description

[Edwin Takahashi (:egao | infrequent contributor)]

Requested by :bc while working on https://bugzilla.mozilla.org/show_bug.cgi?id=1484238.

Start by adding unit tests for the refactored reverse, forward methods for ADBAndroid class.

Comment 1

[Edwin Takahashi (:egao | infrequent contributor)]

Quick glance over other bugs, looks like we're converting over to PyTest from UnitTest. Will go ahead and consider implementing this bug with PyTest.

Comment 2

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1488590 - Add tests to mozdevice::adb.py

Created tests/ subdirectory under mozdevice.
Added conftest.py and populated with wrappers for the methods under test.
Added test_socket_connections.py with basic tests for new methods and some coverage of legacy/deprecated methods.

Comment 3

[Edwin Takahashi (:egao | infrequent contributor)]

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1edd3d0f6380f63f1d46fba3594b43db38c64556

Comment 4

[Geoff Brown [:gbrown]]

(In reply to Edwin Gao ( :egao ) from comment #3)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=1edd3d0f6380f63f1d46fba3594b43db38c64556

The cppunit failures there are an expected consequence of the artifact build -- nothing to worry about. Use a non-artifact build to run cppunit tests.

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 9006973 [details]
Bug 1488590 - Add tests to mozdevice::adb.py

Andrew Halberstadt [:ahal] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4b0ce77a140
Add tests to mozdevice::adb.py r=ahal

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/c4b0ce77a140