Closed Bug 1488590 Opened Last year Closed Last year
Add tests to mozdevice::adb
Requested by :bc while working on https://bugzilla.mozilla.org/show_bug.cgi?id=1484238. Start by adding unit tests for the refactored reverse, forward methods for ADBAndroid class.
Quick glance over other bugs, looks like we're converting over to PyTest from UnitTest. Will go ahead and consider implementing this bug with PyTest.
Assignee: nobody → egao
Created tests/ subdirectory under mozdevice. Added conftest.py and populated with wrappers for the methods under test. Added test_socket_connections.py with basic tests for new methods and some coverage of legacy/deprecated methods.
Attachment #9006973 - Attachment description: Bug 1488590 - Add tests to mozdevice::adb.py r?gbrown → Bug 1488590 - Add tests to mozdevice::adb.py
(In reply to Edwin Gao ( :egao ) from comment #3) > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=1edd3d0f6380f63f1d46fba3594b43db38c64556 The cppunit failures there are an expected consequence of the artifact build -- nothing to worry about. Use a non-artifact build to run cppunit tests.
Comment on attachment 9006973 [details] Bug 1488590 - Add tests to mozdevice::adb.py Andrew Halberstadt [:ahal] has approved the revision.
Attachment #9006973 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/c4b0ce77a140 Add tests to mozdevice::adb.py r=ahal
You need to log in before you can comment on or make changes to this bug.