1488593 - move family safety detection/root importing to background thread (since it's enabled by default)

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) [:keeler]]

Currently the Family Safety feature in PSM is set to "detect only". However, since we're not collecting telemetry for it any longer (bug 1346297), having a detect-only mode doesn't make much sense. We should disable it altogether by default (and remove the feature entirely when Windows 8.1 market shared reaches some small value (e.g. what XP was at when we dropped support for it?)).

Comment 1

[Dana Keeler (she/her) [:keeler]]

Attachment: bug 1488593 - disable family safety detection by default r?jcj

As of bug 1346297, we don't collect telemetry for the family safety root
feature. At this point, it makes the most sense to disable the entire feature by
default.

Comment 2

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 9006411 [details]
bug 1488593 - disable family safety detection by default r?jcj

J.C. Jones [:jcj] (he/him) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df1f14eb13ef
disable family safety detection by default r=jcj

Comment 4

[Andreea Pavel [:apavel]]

Backed out for build bustages on a closed tree

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=df1f14eb13efba1cb6c86b7f512c058bb6172f82

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=197706220&repo=autoland&lineNumber=33972

Backout: https://hg.mozilla.org/integration/autoland/rev/249c11943fe25c5f94a143ed176fc00490b1cb8a

Comment 5

[Dana Keeler (she/her) [:keeler]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3917a67c5261095d61cd70b43676cf5fc82bd2d7

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85ec0c9fb5c3
disable family safety detection by default r=jcj

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/85ec0c9fb5c3

Comment 8

[Anna]

This change doesn't seem to do anything because you're still reading the value from the pref security.family_safety.mode, no?

Preferences::GetUint(kFamilySafetyModePref, 1) gets the value from kFamilySafetyModePref and defaults to 1 if it doesn't exist, right? But since security.family_safety.mode is defined in obj-x86_64-pc-linux-gnu/dist/bin/greprefs.js and security/manager/ssl/security-prefs.js with value 2, changing the fallback default from 1 to 0 doesn't really do anything.

https://dxr.mozilla.org/mozilla-central/search?q=family_safety

Comment 9

[Dana Keeler (she/her) [:keeler]]

Good catch. I forgot we did that. What we really need to do here is move the family safety detection/importing to the background thread as well.

Comment 10

[Dana Keeler (she/her) [:keeler]]

Attachment: bug 1488593 - move family safety root detection to background thread r?dipen

A previous patch in this bug made the incorrect assumption that we had disabled
the family safety root detection/importing feature by default. In reality, we
enabled it by default in bug 1282871.

In bug 1487258 we moved enterprise root loading to a background thread so as to
not block the main thread. This patch does the same with the family safety
feature.

Comment 11

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 9007941 [details]
bug 1488593 - move family safety root detection to background thread r?dipen

J.C. Jones [:jcj] (he/him) has approved the revision.

Comment 12

[Dipen Patel [:dipen]]

Comment on attachment 9007941 [details]
bug 1488593 - move family safety root detection to background thread r?dipen

Dipen Patel [:dipen] has approved the revision.

Comment 13

[Dana Keeler (she/her) [:keeler]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ca02d8e8b874110a1af3c5f2ca3e65aedae32bd

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83ca9766b8fe
move family safety root detection to background thread r=dipen,jcj

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/83ca9766b8fe