Closed Bug 1488593 Opened Last year Closed Last year

move family safety detection/root importing to background thread (since it's enabled by default)

Categories

(Core :: Security: PSM, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: keeler, Assigned: keeler)

Details

(Whiteboard: [psm-assigned])

Attachments

(2 files)

Currently the Family Safety feature in PSM is set to "detect only". However, since we're not collecting telemetry for it any longer (bug 1346297), having a detect-only mode doesn't make much sense. We should disable it altogether by default (and remove the feature entirely when Windows 8.1 market shared reaches some small value (e.g. what XP was at when we dropped support for it?)).
As of bug 1346297, we don't collect telemetry for the family safety root
feature. At this point, it makes the most sense to disable the entire feature by
default.
Comment on attachment 9006411 [details]
bug 1488593 - disable family safety detection by default r?jcj

J.C. Jones [:jcj] (he/him) has approved the revision.
Attachment #9006411 - Flags: review+
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df1f14eb13ef
disable family safety detection by default r=jcj
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85ec0c9fb5c3
disable family safety detection by default r=jcj
https://hg.mozilla.org/mozilla-central/rev/85ec0c9fb5c3
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
This change doesn't seem to do anything because you're still reading the value from the pref security.family_safety.mode, no?

Preferences::GetUint(kFamilySafetyModePref, 1) gets the value from kFamilySafetyModePref and defaults to 1 if it doesn't exist, right? But since security.family_safety.mode is defined in obj-x86_64-pc-linux-gnu/dist/bin/greprefs.js and security/manager/ssl/security-prefs.js with value 2, changing the fallback default from 1 to 0 doesn't really do anything.

https://dxr.mozilla.org/mozilla-central/search?q=family_safety
Flags: needinfo?(dkeeler)
Good catch. I forgot we did that. What we really need to do here is move the family safety detection/importing to the background thread as well.
Status: RESOLVED → REOPENED
Flags: needinfo?(dkeeler)
Resolution: FIXED → ---
Summary: disable family safety detection by default → move family safety detection/root importing to background thread (since it's enabled by default)
A previous patch in this bug made the incorrect assumption that we had disabled
the family safety root detection/importing feature by default. In reality, we
enabled it by default in bug 1282871.

In bug 1487258 we moved enterprise root loading to a background thread so as to
not block the main thread. This patch does the same with the family safety
feature.
Comment on attachment 9007941 [details]
bug 1488593 - move family safety root detection to background thread r?dipen

J.C. Jones [:jcj] (he/him) has approved the revision.
Attachment #9007941 - Flags: review+
Comment on attachment 9007941 [details]
bug 1488593 - move family safety root detection to background thread r?dipen

Dipen Patel [:dipen] has approved the revision.
Attachment #9007941 - Flags: review+
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83ca9766b8fe
move family safety root detection to background thread r=dipen,jcj
https://hg.mozilla.org/mozilla-central/rev/83ca9766b8fe
Status: REOPENED → RESOLVED
Closed: Last yearLast year
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.