1488631 - Remove annotations that the plugin doesn't handle.

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1488631 - Remove annotations that the clang plugin doesn't handle. r?andi

As per bug 1487622, annotations have side effects on codegen, one of
which changes a leak signature that the wpt harness doesn't match
against its whitelist anymore.

Interestingly, while looking at the issue, I found multiple moz_*
annotations that weren't actually looked for by the clang plugin,
making them useless. Even more interestingly, removing them changes
codegen in such a way that the leak signature mentioned above is not
altered anymore.

Comment 2

[Mike Hommey [:glandium]]

I'll repurpose bug 1487622 to address the core problem. I'm trying to rewrite the plugin so that it doesn't use annotations.

Comment 3

[Mike Hommey [:glandium]]

Note that I left all the annotations in code, in case we'd decide to actually do something about them in the future, but it's still better to avoid adding actual annotations (that impact codegen) when we don't care about them. At least it makes it clearer that those are actually no-ops.

Comment 4

[Andi [:andi]]

Comment on attachment 9006431 [details]
Bug 1488631 - Remove annotations that the clang plugin doesn't handle. r?andi

Andi-Bogdan Postelnicu [:andi] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1e83e95d0a9
Remove annotations that the clang plugin doesn't handle. r=andi

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/e1e83e95d0a9