1488656 - [wpt-sync] Sync PR 12839 - Fix :scope selector matching in the case of DocumentFragment/ShadowRoot

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 12839 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12839
Details from upstream follow.

Momoko Sumida <[e-mail]> wrote:
>  Fix :scope selector matching in the case of DocumentFragment/ShadowRoot
>  
>  When used in querySelector and querySelectorAll, :scope should match
>  the element or the DocumentFragment/ShadowRoot the querySelector is
>  called on. However, WPT adeed in crrev.com/c/1158445 shows that :scope
>  matches nothing when querySelector is called on shadow root, while it
>  works fine when querySelector is called on true element.
>  This CL fixes :scope selector matching process so that :scope itself
>  matches DocumentFragment/ShadowRoot when querySelector is called on
>  DocumentFragment/ShadowRoot. Tests for DocumentFragment are also added
>  in this CL.
>  
>  Link to the spec:
>  https://drafts.csswg.org/selectors-4/#the-scope-pseudo
>  
>  Link to related issue:
>  https://github.com/w3c/csswg-drafts/issues/3016
>  
>  Link to related CL:
>  crrev.com/c/1158445
>  
>  Bug: 859692
>  Change-Id: If20fc4b122d93a553dc478be0ee958958340a34f
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1203472
>  WPT-Export-Revision: 725646573b533911debd393a6edc500b6eb64a9e

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cbb330bcae107543dcc229b12e5e66f8b865934

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d934576efa863a81adcc67540bcdcc4c98ef6bc

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8391c1c15526019637a17a33904bd03ea96f73b

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab76d9df7c8b46c5c69427a4c861daf9bae48471

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6008ac1b08e4d2a1aaa119f28a219f557f5beb5a

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=33f690255c361cebfdf4ae03ba76ce85b19e3d72

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d015e25e2a40689bc5acc65b0a3b6153d5c544d

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9ac926fde2e8509bc83a517d4971b0484aad82c

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3febe9057980edd8eaeb4c4036ddc7e6cbe34a1

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=735d01c210e2165a8c4ec12503f34f230e678f43

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Ran 1 tests and 9 subtests
OK     : 1
PASS   : 3
FAIL   : 6

New tests that have failures or other problems:
/css/selectors/scope-selector.html
    Selecting descendants of document fragment with :scope should work: FAIL
    Selecting descendants of nested shadow root with :scope should work: FAIL
    Selecting direct child of document fragment with :scope should work: FAIL
    Selecting direct child of nested shadow root with :scope should work: FAIL

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e307e2cc9a8
[wpt PR 12839] - Fix :scope selector matching in the case of DocumentFragment/ShadowRoot, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ccd436a9778
[wpt PR 12839] - Update wpt metadata, a=testonly

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5e307e2cc9a8
https://hg.mozilla.org/mozilla-central/rev/4ccd436a9778

Comment 14

[Cristina Coroiu [:ccoroiu]]

Backed out for WPT mass failure at /fullscreen/idlharness.window.html

Backout: https://hg.mozilla.org/mozilla-central/rev/e1a681345945ab8c8b8270afcd2f62bf042226c2

Failure push: 
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed,busted,exception&classifiedState=unclassified&revision=be6801cdeb537afa655bbd67d12ead8dc01c6c38

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3f3f67d1c0bf5359ac39ddddec5999ceb928e7ca

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=199470643&repo=mozilla-central&lineNumber=1487

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40c8e72fa87d
[wpt PR 12839] - Fix :scope selector matching in the case of DocumentFragment/ShadowRoot, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f769ef4c0b8
[wpt PR 12839] - Update wpt metadata, a=testonly

Comment 16

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/40c8e72fa87d
https://hg.mozilla.org/mozilla-central/rev/3f769ef4c0b8

Comment 17

[falsandtru]

Looks like not fixed on 64.0.2. Any problems?