1488659 - Remove XPCOM registration of nsICharsetDetector

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Henri Sivonen (:hsivonen)]

nsICharsetDetector is only used from C++.

Comment 1

[(no longer active)]

Is this even possible given that this component is used in these categories?

https://searchfox.org/mozilla-central/rev/6201a9e0067cf6af118c6a99ae9314b8ceb2c4d5/intl/chardet/nsChardetModule.cpp#33
https://searchfox.org/mozilla-central/rev/6201a9e0067cf6af118c6a99ae9314b8ceb2c4d5/extensions/universalchardet/src/xpcom/nsUniversalCharDetModule.cpp#41

Comment 2

[(no longer active)]

The XPCOM category seems to be unused to me...

Comment 3

[Henri Sivonen (:hsivonen)]

(In reply to :Ehsan Akhgari from comment #1)
> Is this even possible given that this component is used in these categories?

It's possible. There are three implementation classes: Japanese, Russian and Ukrainian. There's one instantiation site: https://searchfox.org/mozilla-central/source/parser/html/nsHtml5StreamParser.cpp#209

All that's needed is exposing three constructors or factory methods and making the instantiation site check for three magic strings to decide which one to use.

Comment 4

[(no longer active)]

Attachment: Bug 1488659 - Part 1: Remove the XPCOM registrations for character detector classes; r=hsivonen

Comment 5

[(no longer active)]

Attachment: Bug 1488659 - Part 2: Remove some dead code and mark the remaining detector classes as final; r=hsivonen

Depends on D5392

Comment 6

[Masatoshi Kimura [:emk]]

Flagging Jorg.K as c-c still has a reference to nsICharsetDetector:
https://dxr.mozilla.org/comm-central/rev/e5e1510b8d914bfa8439b21ba3f73e4f2e83e957/mailnews/base/util/nsMsgUtils.cpp#1941-1955

Please see here how to rewrite the code:
https://phabricator.services.mozilla.com/D5392#C122482NL203

Comment 7

[Henri Sivonen (:hsivonen)]

Comment on attachment 9007652 [details]
Bug 1488659 - Part 1: Remove the XPCOM registrations for character detector classes; r=hsivonen

Henri Sivonen (:hsivonen) has approved the revision.

Comment 8

[Henri Sivonen (:hsivonen)]

Comment on attachment 9007653 [details]
Bug 1488659 - Part 2: Remove some dead code and mark the remaining detector classes as final; r=hsivonen

Henri Sivonen (:hsivonen) has approved the revision.

Comment 9

[Jorg K (CEST = GMT+2)]

(In reply to Masatoshi Kimura [:emk] from comment #6)
> Flagging Jorg.K as c-c still has a reference to nsICharsetDetector:
Thanks, I filed bug 1489949 for the C-C work. Awaiting the final version of the code here to copy/paste.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d94ad30a3001
Part 1: Remove the XPCOM registrations for character detector classes; r=hsivonen
https://hg.mozilla.org/integration/mozilla-inbound/rev/68ad5bdca1ce
Part 2: Remove some dead code and mark the remaining detector classes as final; r=hsivonen

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d94ad30a3001
https://hg.mozilla.org/mozilla-central/rev/68ad5bdca1ce