1488684 - Devirtualize more of layout

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Easy pickings in layout/ (as I am working nearby anyway).

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1488684 - Made nsIFrame-derived classes and some others 'final' where possible - r?dbaron

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1488684 - Made some layout methods 'final' or non-virtual - r?dbaron

Though some of these are not strictly necessary because they are inside 'final'
classes, I think they're worth adding anyway, because:
- The 'final' keyword becomes more obvious when looking at methods without the
  wider context in sight (e.g., in reviews or searchfox).
- If one day any of these classes becomes non-final, it would keep the final
  attribute on all methods by default, and force the programmer to explicitly
  remove 'final' from the methods that need to be overridden.

Depends on D5020

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 9006517 [details]
Bug 1488684 - Made nsIFrame-derived classes and some others 'final' where possible - r?dbaron

David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 has approved the revision.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 9006518 [details]
Bug 1488684 - Made some layout methods 'final' or non-virtual - r?dbaron

David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52dabf91acd0
Made nsIFrame-derived classes and some others 'final' where possible - r=dbaron

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc3b69fb4426
Made some layout methods 'final' or non-virtual - r=dbaron

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/52dabf91acd0

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Reopening this bug, because the 2nd patch didn't make it to central just yet (Lando separated the patches in autoland, and I didn't put part numbers in the descriptions, so the sheriff didn't notice they were linked.)

The 2nd patch should go through in the next merge in a few hours...

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/bc3b69fb4426