1488715 - Cannot disable Snippets from Prefs in some profiles

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Tim Spurway [:tspurway]]

STR:

Go to Firefox Nightly -> Preferences -> Home and check *off* the "Snippets" check box.

Restart Firefox.

Open a newtab.

Expected:  there is no Snippet on the newtab page

Actual: I see a Snippet

Note that I can only reproduce this in certain profiles.  :gcp, you originally noticed this in one of your profiles, maybe we can figure out the common ground?  I have been able to reproduce more frequently when browser.newtabpage.activity-stream.asrouterExperimentEnabled = true

Comment 1

[Gian-Carlo Pascutto [:gcp]]

That's set to false on my affected profile.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

FWIW I've only seen this on the first (home) page after startup so far. Subsequent openings of new tabs seem to work correctly.

Comment 3

[Tim Spurway [:tspurway]]

So I can confirm that when browser.newtabpage.activity-stream.asrouterExperimentEnabled = true, the Snippets pref is ignored, which I don't believe is intended behaviour, but is only severe if we are using this pref for active experiments (:k88hudson, is this the case?)

I still can't repro otherwise.  :gcp, does your profile have any extensions or significant non-default preferences set?  Can it be reproduced in Beta and Release?

Comment 4

[Kate Hudson :k88hudson]

Looks like this is an existing issue, should be fixed by Bug 1488758

Comment 5

[Gian-Carlo Pascutto [:gcp]]

The profile I'm seeing this on is almost pristine, so no.

Comment 6

[Ursula Sarracini (:ursula)]

Fixed by Bug 1488758, closing this

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/95f8e6265f24