Closed Bug 1488809 Opened 6 years ago Closed 6 years ago

Perma failing browser/base/content/test/trackingUI/browser_trackingUI_state.js when Gecko 64 merges to Beta on 2018-10-15

Categories

(Firefox :: Site Identity, defect, P1)

Product:
Firefox
Component:
Site Identity
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 + fixed
firefox64 + verified

People

(Reporter: dvarga, Assigned: johannh)

Details

Attachments

(1 file)

Bug 1488809 - Correctly account for non-CB-UI tracking protection cases in browser_trackingUI_state.js. r=Ehsan
46 bytes, text/x-phabricator-request
ehsan.akhgari
: review+
Details | Review 
[Tracking Requested - why for this release]:

Central as beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ed5920b72e980e260986e0eeaf3240c6323d3fe&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=pending&filter-resultStatus=running&filter-classifiedState=unclassified&filter-searchStr=Linux%20x64%20asan%20Mochitests%20with%20e10s%20test-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-10%20M-e10s(bc10)&selectedJob=197622632

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=197622632&repo=try&lineNumber=1877

This may be related to: https://hg.mozilla.org/mozilla-central/rev/9a4199857e74

[task 2018-09-05T14:41:53.042Z] 14:41:53     INFO - Buffered messages finished
[task 2018-09-05T14:41:53.044Z] 14:41:53     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/trackingUI/browser_trackingUI_state.js | unblockButton is visible - 
[task 2018-09-05T14:41:53.044Z] 14:41:53     INFO - Stack trace:
[task 2018-09-05T14:41:53.045Z] 14:41:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/trackingUI/browser_trackingUI_state.js:testTrackingPage:150
[task 2018-09-05T14:41:53.046Z] 14:41:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/trackingUI/browser_trackingUI_state.js:testContentBlockingEnabled:268
[task 2018-09-05T14:41:53.052Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | unblockButtonPrivate is hidden - 
[task 2018-09-05T14:41:53.058Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | blocking not detected label is hidden - 
[task 2018-09-05T14:41:53.059Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | blocking detected label is visible - 
[task 2018-09-05T14:41:53.063Z] 14:41:53     INFO - Disable CB for the page (which reloads the page)
[task 2018-09-05T14:41:53.064Z] 14:41:53     INFO - Wait tab event: load
[task 2018-09-05T14:41:53.065Z] 14:41:53     INFO - Tab event received: load
[task 2018-09-05T14:41:53.065Z] 14:41:53     INFO - Tracking content must be white-listed and not blocked
[task 2018-09-05T14:41:53.066Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | trackers are detected - 
[task 2018-09-05T14:41:53.067Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | content shows exception - 
[task 2018-09-05T14:41:53.070Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | shield is active - 
[task 2018-09-05T14:41:53.072Z] 14:41:53     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-09-05T14:41:53.073Z] 14:41:53     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/trackingUI/browser_trackingUI_state.js | shield shows exception - Got false, expected true
[task 2018-09-05T14:41:53.074Z] 14:41:53     INFO - Stack trace:
[task 2018-09-05T14:41:53.076Z] 14:41:53     INFO - chrome://mochikit/content/browser-test.js:test_is:1304
[task 2018-09-05T14:41:53.077Z] 14:41:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/trackingUI/browser_trackingUI_state.js:testTrackingPageUnblocked:182
[task 2018-09-05T14:41:53.078Z] 14:41:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/trackingUI/browser_trackingUI_state.js:testContentBlockingEnabled:275
[task 2018-09-05T14:41:53.082Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | correct tooltip - 
[task 2018-09-05T14:41:53.083Z] 14:41:53     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-09-05T14:41:53.084Z] 14:41:53     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/trackingUI/browser_trackingUI_state.js | icon box is visible - Got false, expected true
[task 2018-09-05T14:41:53.085Z] 14:41:53     INFO - Stack trace:
[task 2018-09-05T14:41:53.085Z] 14:41:53     INFO - chrome://mochikit/content/browser-test.js:test_is:1304
[task 2018-09-05T14:41:53.086Z] 14:41:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/trackingUI/browser_trackingUI_state.js:testTrackingPageUnblocked:187
[task 2018-09-05T14:41:53.088Z] 14:41:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/trackingUI/browser_trackingUI_state.js:testContentBlockingEnabled:275
[task 2018-09-05T14:41:53.089Z] 14:41:53     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-09-05T14:41:53.090Z] 14:41:53     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/trackingUI/browser_trackingUI_state.js | blockButton is not visible - Got true, expected false
[task 2018-09-05T14:41:53.092Z] 14:41:53     INFO - Stack trace:
[task 2018-09-05T14:41:53.093Z] 14:41:53     INFO - chrome://mochikit/content/browser-test.js:test_is:1304
[task 2018-09-05T14:41:53.094Z] 14:41:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/trackingUI/browser_trackingUI_state.js:testTrackingPageUnblocked:189
[task 2018-09-05T14:41:53.095Z] 14:41:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/trackingUI/browser_trackingUI_state.js:testContentBlockingEnabled:275
[task 2018-09-05T14:41:53.096Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | unblockButton is hidden - 
[task 2018-09-05T14:41:53.099Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | disabled label is visible - 
[task 2018-09-05T14:41:53.100Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | blocking not detected label is hidden - 
[task 2018-09-05T14:41:53.101Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | blocking detected label is visible - 
[task 2018-09-05T14:41:53.106Z] 14:41:53     INFO - Re-enable TP for the page (which reloads the page)
[task 2018-09-05T14:41:53.107Z] 14:41:53     INFO - Wait tab event: load
[task 2018-09-05T14:41:53.338Z] 14:41:53     INFO - Tab event received: load
[task 2018-09-05T14:41:53.340Z] 14:41:53     INFO - Tracking content must be blocked
[task 2018-09-05T14:41:53.350Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | trackers are detected - 
[task 2018-09-05T14:41:53.351Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | content shows no exception - 
[task 2018-09-05T14:41:53.353Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | icon box is not visible - 
[task 2018-09-05T14:41:53.354Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | shield is not active - 
[task 2018-09-05T14:41:53.359Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | icon box shows no exception - 
[task 2018-09-05T14:41:53.362Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | correct tooltip - 
[task 2018-09-05T14:41:53.366Z] 14:41:53     INFO - TEST-PASS | browser/base/content/test/trackingUI/browser_trackingUI_state.js | blockButton is hidden - 
[task 2018-09-05T14:41:53.370Z] 14:41:53     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-09-05T14:41:53.371Z] 14:41:53     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/trackingUI/browser_trackingUI_state.js | unblockButton is visible -
Flags: needinfo?(ehsan)
Assignee: nobody → ehsan
Flags: needinfo?(ehsan)
See Also: → 1489007
I suspect there is a real bug here somewhere...  Filed bug 1489007 for now.
Don't know what bug 1489007 has to do with that, this is about the unblock button not being visible...
Priority: -- → P1
Assignee: ehsan → jhofmann
Status: NEW → ASSIGNED
See Also: 1489007 → 
I guess the root of the problem was me adding these conditional checks based on whether contentblocking UI is enabled or not. That makes it too easy to break this test because only one condition will be run.

I guess there's not really a point in refactoring this test right now, I'll just take it as a lesson into the future...
Comment on attachment 9006898 [details]
Bug 1488809 - Correctly account for non-CB-UI tracking protection cases in browser_trackingUI_state.js. r=Ehsan

:Ehsan Akhgari has approved the revision.
Attachment #9006898 - Flags: review+
This absolutely affects 63 when we get to late beta, I think, and needs to be backported.
status-firefox63: unaffected → affected
tracking-firefox63: --- → ?
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/97aa4648a7f6
Correctly account for non-CB-UI tracking protection cases in browser_trackingUI_state.js. r=Ehsan
(In reply to :Ehsan Akhgari from comment #6)
> This absolutely affects 63 when we get to late beta, I think, and needs to
> be backported.

s/late beta/beta/
https://hg.mozilla.org/mozilla-central/rev/97aa4648a7f6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: