1488855 - InterpreterStack is part of JSContext

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P5)

Description

[Jon Coppeard (:jonco)]

We have one main thread JSContext but also one per helper thread, so it seems like InterpreterStack should live in the JSRuntime.

Comment 1

[Diego Pino]

Attachment: 0001-Bug-1488855-Move-InterpreterStack-from-JSContext-to-.patch

Giving this a try. I tried to make the patch simple and kept JSContext->interpreterStack() as a wrapper for JSRuntime->interpretStack(), although it can be removed. I dunno if the patch is correct either (I don't see where interpreterStack_ is written).

Comment 2

[Diego Pino]

Attachment: Bug-1488855-Move-InterpreterStack-from-JSContext-to-.patch

Updated patch (wrong patch format).

Comment 3

[Jon Coppeard (:jonco)]

Comment on attachment 9014820 [details] [diff] [review]
Bug-1488855-Move-InterpreterStack-from-JSContext-to-.patch

Review of attachment 9014820 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!

It's fine to leave the JSContext method as a wrapper since most places we need to access the stack we only have a JSContext anyway.

::: js/src/vm/Runtime.h
@@ +230,5 @@
>      friend class js::jit::JitActivation;
>      friend class js::jit::CompileRuntime;
>  
> +    /* Space for interpreter frames. */
> +    js::ThreadData<js::InterpreterStack> interpreterStack_;

Can you make this MainThreadData instead of ThreadData?  This matches the other fields in JSRuntime that are only supposed to be accessed from the main thread.

Comment 4

[Jon Coppeard (:jonco)]

Assigning to you.  Let me know if you need me to queue a try build.

Comment 5

[Diego Pino]

Attachment: Bug-1488855-Move-InterpreterStack-from-JSContext-to-.patch

Updated patch.

Comment 6

[Jon Coppeard (:jonco)]

Comment on attachment 9015477 [details] [diff] [review]
Bug-1488855-Move-InterpreterStack-from-JSContext-to-.patch

Review of attachment 9015477 [details] [diff] [review]:
-----------------------------------------------------------------

Look good.

Comment 7

[Diego Pino]

Treeherder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=85ad97ddaefbfd019bcc4a000c1ab641facb86e5

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d49a5d674e00
Move InterpreterStack from JSContext to JSRuntime. r=jonco

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d49a5d674e00