1488881 - Re-enable the NUMBER_OF_PROFILES probe

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[Dave Townsend [:mossop]]

With profile-per-install due to land in Firefox 64 we'd like to track the number of profiles users have on their machines, we expect it to rise a little but not a lot.

The NUMBER_OF_PROFILES probe exists but has expired so I'd like to re-enable it and ideally uplift to at least beta so we have some historic data.

Comment 1

[Dave Townsend [:mossop]]

Attachment: request.txt

Data collection request.

Comment 2

[Dave Townsend [:mossop]]

Attachment: Bug 1488881: Re-enable the NUMBER_OF_PROFILES probe. r=chutten

Comment 3

[Chris H-C :chutten]

Comment on attachment 9006662 [details]
request.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Standard Telemetry mechanisms apply (probe dictionary, definition files, ...).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Standard Telemetry mechanisms apply (Data Choices checkbox in about:preferences)

    If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A expires in 70

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Either 1 or 2 depending on whether you think profiles are an implementation detail or created through user interaction.

    Is the data collection request for default-on or default-off?

Default on.

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. Mossop will be responsible for removing or renewing this probe before expiry.

---
Result: datareview+

Comment 4

[Alessio Placitelli [:Dexter]]

Comment on attachment 9006663 [details]
Bug 1488881: Re-enable the NUMBER_OF_PROFILES probe. r=chutten

Alessio Placitelli [:Dexter] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07ce49ea7662
Re-enable the NUMBER_OF_PROFILES probe. r=Dexter

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/07ce49ea7662

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 9006663 [details]
Bug 1488881: Re-enable the NUMBER_OF_PROFILES probe. r=chutten

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: N/A
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Simple change to Histograms.json.
[String changes made/needed]: None

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9006663 [details]
Bug 1488881: Re-enable the NUMBER_OF_PROFILES probe. r=chutten

Uplift approved for 63 beta 7, thanks.

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4b77bd43d1a4