1488893 - version-control-tools CI cache is busted

Status: RESOLVED WONTFIX

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Connor Sheehan [:sheehan]]

The version-control-tools cache has a bug in it somewhere that is causing new code to be run against old test files. This happened previously and I worked around it by refreshing the vct Docker image, however that is not a sustainable solution. We should fix the cache so it works as intended (simply providing a starting point from which to pull down the new changes, instead of creating the test environment in a fresh vct clone).

An example showing the bug: in fe5f53b87f9f we removed Mozreview from the configwizard code review step and instead recommend users register for and install Phabricator. Looking at the test output for `test-codereview.t` at https://tools.taskcluster.net/groups/F6YkUQzcTKifXjyLzTqXeg/tasks/F6YkUQzcTKifXjyLzTqXeg/runs/0/logs/public%2Flogs%2Flive.log, we can see the following:

--- /vct-cache/hgext/configwizard/tests/test-codereview.t
+++ /vct-cache/hgext/configwizard/tests/test-codereview.t.err
@@ -32,6 +32,12 @@
   
   To begin, press the enter/return key.
    <RETURN>
+  Will you be submitting commits to Mozilla (Yn)?  y
+  Commits to Mozilla projects are typically sent to Phabricator. This is the
+  preferred code review tool at Mozilla.
+  Phabricator installation instructions are here
+  http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
+  
 
 reviewboard is enabled when requested
 
@@ -44,46 +50,15 @@
   To begin, press the enter/return key.
    <RETURN>
   Will you be submitting commits to Mozilla (Yn)?  y
-  Commits to Mozilla projects are typically sent to MozReview. This is the
+  Commits to Mozilla projects are typically sent to Phabricator. This is the
   preferred code review tool at Mozilla.
+  Phabricator installation instructions are here
+  http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

The "+" lines are new, unexpected output and the "-" lines are output that was expected but are not present. From this we can see that the new test output is being generated by the `configwizard` command, but the test is expecting the output from the commit used to build the Docker image.

Comment 1

[Connor Sheehan [:sheehan]]

We don't use the TC CI anymore.