1488938 - Rewrite callers of firstChild/lastChild/childNodes/previousSibling/nextSibling with firstElementChild/lastElementChild/children/previousElementSibling/nextElementSibling round 2

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P1)

Description

[Brendan Dahl [:bdahl]]

Now that more tests are running it looks like we need to do another round of rewrites.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: childNodes-inst.patch

Patch for instrumentation run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b8397f9fbbeb7bd6cb98a79ece050779dfeaf02&filter-tier=1&filter-tier=2&filter-tier=3

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Marking as P1 as this appears to be actively being worked on.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: Bug 1488938 - Migrate two more nextSibling/previousSibling callers to use element variation;r=Gijs

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Bug 1488938 - Round two: migrate mochitest-browser tests to use element variations of firstChild, etc;r=Gijs

This is a follow up to Bug 1482667. The list of callers was gathered by instrumenting
the webidl calls to these methods and dumping JS stack when they are called in browser.xul.

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: childNodes-inst.patch

Updated instrumentation patch

Comment 6

[:Gijs (he/him)]

Comment on attachment 9007012 [details]
Bug 1488938 - Round two: migrate mochitest-browser tests to use element variations of firstChild, etc;r=Gijs

:Gijs (he/him) has approved the revision.

Comment 7

[:Gijs (he/him)]

Comment on attachment 9007011 [details]
Bug 1488938 - Migrate two more nextSibling/previousSibling callers to use element variation;r=Gijs

:Gijs (he/him) has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8936414659b
Migrate two more nextSibling/previousSibling callers to use element variation;r=Gijs

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac058fbbed8c
Round two: migrate mochitest-browser tests to use element variations of firstChild, etc;r=Gijs

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/e8936414659b
https://hg.mozilla.org/mozilla-central/rev/ac058fbbed8c