Closed
Bug 1488946
Opened 3 years ago
Closed 2 years ago
browser_aboutSearchReset.js is going to permafail when the Gecko version number is bumped to 65 on 2018-10-22
Categories
(Firefox :: Search, defect, P1)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 66
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox62 | --- | unaffected |
firefox63 | --- | unaffected |
firefox64 | --- | unaffected |
firefox65 | + | disabled |
firefox66 | --- | fixed |
People
(Reporter: apavel, Assigned: daleharvey)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
[Tracking Requested - why for this release]: Central as Beta simulation Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=701dd8f52ed8236eb93a1bf297ef81997a391170&selectedJob=197614363 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=197614363&repo=try&lineNumber=4498 [task 2018-09-05T14:19:29.624Z] 14:19:29 INFO - TEST-START | browser/components/search/test/browser_aboutSearchReset.js [task 2018-09-05T14:19:29.645Z] 14:19:29 INFO - TEST-INFO | started process screentopng [task 2018-09-05T14:19:30.485Z] 14:19:30 INFO - TEST-INFO | screentopng: exit 0 [task 2018-09-05T14:19:30.490Z] 14:19:30 INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_aboutSearchReset.js | histogram has expected content - [149,23,173] deepEqual [0,0,0,0,0,0] - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_aboutSearchReset.js :: checkTelemetryRecords :: line 28 [task 2018-09-05T14:19:30.491Z] 14:19:30 INFO - Stack trace: [task 2018-09-05T14:19:30.491Z] 14:19:30 INFO - chrome://mochitests/content/browser/browser/components/search/test/browser_aboutSearchReset.js:checkTelemetryRecords:28 [task 2018-09-05T14:19:30.493Z] 14:19:30 INFO - chrome://mochitests/content/browser/browser/components/search/test/browser_aboutSearchReset.js:test/<:143 [task 2018-09-05T14:19:30.494Z] 14:19:30 INFO - chrome://mochitests/content/browser/browser/components/search/test/browser_aboutSearchReset.js:test:140 [task 2018-09-05T14:19:30.495Z] 14:19:30 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1133 [task 2018-09-05T14:19:30.497Z] 14:19:30 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995 [task 2018-09-05T14:19:30.499Z] 14:19:30 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795 [task 2018-09-05T14:19:30.500Z] 14:19:30 INFO - Test the 'Keep Current Settings' button. [task 2018-09-05T14:19:30.501Z] 14:19:30 INFO - GECKO(2372) | ++DOCSHELL 0xe9a0c400 == 3 [pid = 2494] [id = {af04ca3f-2c2f-452a-8b98-fb832ac7fbfb}] [task 2018-09-05T14:19:30.502Z] 14:19:30 INFO - GECKO(2372) | ++DOMWINDOW == 6 (0xe9804940) [pid = 2494] [serial = 6] [outer = (nil)] [task 2018-09-05T14:19:30.502Z] 14:19:30 INFO - Wait tab event: load [task 2018-09-05T14:19:30.504Z] 14:19:30 INFO - GECKO(2372) | ++DOMWINDOW == 7 (0xe9a0d800) [pid = 2494] [serial = 7] [outer = 0xe9804940] [task 2018-09-05T14:19:30.505Z] 14:19:30 INFO - GECKO(2372) | ++DOMWINDOW == 8 (0xe9a0e400) [pid = 2494] [serial = 8] [outer = 0xe9804940] [task 2018-09-05T14:19:30.506Z] 14:19:30 INFO - GECKO(2372) | --DOCSHELL 0xea43b800 == 0 [pid = 2555] [id = {e583a7b0-ea3d-4294-ba42-0b8446aacc14}] [task 2018-09-05T14:19:30.508Z] 14:19:30 INFO - GECKO(2372) | ++DOCSHELL 0xe05d3800 == 7 [pid = 2372] [id = {ee9e2d26-531f-4e03-9824-3911739a56bb}] [task 2018-09-05T14:19:30.509Z] 14:19:30 INFO - GECKO(2372) | ++DOMWINDOW == 19 (0xdf833ee0) [pid = 2372] [serial = 19] [outer = (nil)] [task 2018-09-05T14:19:30.511Z] 14:19:30 INFO - GECKO(2372) | --DOMWINDOW == 7 (0xea436400) [pid = 2494] [serial = 2] [outer = (nil)] [url = about:blank] [task 2018-09-05T14:19:30.536Z] 14:19:30 INFO - GECKO(2372) | ++DOMWINDOW == 20 (0xe07f2000) [pid = 2372] [serial = 20] [outer = 0xdf833ee0] [task 2018-09-05T14:19:30.641Z] 14:19:30 INFO - GECKO(2372) | [Parent 2372, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2088 [task 2018-09-05T14:19:30.643Z] 14:19:30 INFO - GECKO(2372) | [Parent 2372, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2088 [task 2018-09-05T14:19:30.645Z] 14:19:30 INFO - GECKO(2372) | [Parent 2372, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2088 [task 2018-09-05T14:19:30.648Z] 14:19:30 INFO - GECKO(2372) | [Parent 2372, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2088 [task 2018-09-05T14:19:30.679Z] 14:19:30 INFO - GECKO(2372) | ++DOMWINDOW == 21 (0xe05d8400) [pid = 2372] [serial = 21] [outer = 0xdf833ee0] [task 2018-09-05T14:19:30.805Z] 14:19:30 INFO - GECKO(2372) | ++DOMWINDOW == 22 (0xe07f4400) [pid = 2372] [serial = 22] [outer = 0xdf833ee0] [task 2018-09-05T14:19:31.075Z] 14:19:31 INFO - GECKO(2372) | [Parent 2372, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 4015 [task 2018-09-05T14:19:31.206Z] 14:19:31 INFO - Tab event received: load [task 2018-09-05T14:19:31.207Z] 14:19:31 INFO - Running test [task 2018-09-05T14:19:31.209Z] 14:19:31 INFO - Waiting for engine to be added: testEngine.xml [task 2018-09-05T14:19:31.247Z] 14:19:31 INFO - Search engine added: testEngine.xml [task 2018-09-05T14:19:31.250Z] 14:19:31 INFO - GECKO(2372) | JavaScript error: resource://activity-stream/lib/TopSitesFeed.jsm, line 93: TypeError: setting getter-only property "_currentSearchHostname" [task 2018-09-05T14:19:31.308Z] 14:19:31 INFO - TEST-PASS | browser/components/search/test/browser_aboutSearchReset.js | loaded expected url: http://mochi.test:8888/browser/browser/components/search/test/?searchtest=a+search - [task 2018-09-05T14:19:31.313Z] 14:19:31 INFO - TEST-PASS | browser/components/search/test/browser_aboutSearchReset.js | the custom engine is still default - [task 2018-09-05T14:19:31.315Z] 14:19:31 INFO - TEST-PASS | browser/components/search/test/browser_aboutSearchReset.js | the loadPathHash has been fixed - [task 2018-09-05T14:19:31.323Z] 14:19:31 INFO - Not taking screenshot here: see the one that was previously logged [task 2018-09-05T14:19:31.324Z] 14:19:31 INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_aboutSearchReset.js | histogram has expected content - [181,31,225] deepEqual [0,1,0,0,0,0] - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser_aboutSearchReset.js :: checkTelemetryRecords :: line 28 SEARCH_RESET_RESULT is set to expire in firefox 65
Flags: needinfo?(florian)
Updated•3 years ago
|
Summary: browser_aboutSearchReset.js is going to permafail when the Gecko version number is bumped to 65 on 208-10-22 → browser_aboutSearchReset.js is going to permafail when the Gecko version number is bumped to 65 on 2018-10-22
Comment 1•3 years ago
|
||
Mike, do we still need about:searchreset in the product for 65 and later? If we want to keep it we should keep the probe. If not, we should remove the probe, the about: page and the test.
Flags: needinfo?(florian) → needinfo?(mozilla)
Comment 2•3 years ago
|
||
I don't think we'll be using the reset again, but I think that decision is up to mconnor.
Flags: needinfo?(mozilla) → needinfo?(mconnor)
Updated•3 years ago
|
Comment 3•2 years ago
|
||
mconnor, any update here?
Reminder: Version increase is next Monday, 2018-10-22. This needs to be fixed before that.
Justin, can you make a decision on this? Thank you. (In reply to Florian Quèze [:florian] from comment #1) > Mike, do we still need about:searchreset in the product for 65 and later? If > we want to keep it we should keep the probe. If not, we should remove the > probe, the about: page and the test.
Flags: needinfo?(dolske)
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/mozilla-central/rev/e96edcd3f54a Disable browser_aboutSearchReset.js until telemetry probe has been extended to fix permafail on version increase. a=version-increase-fix
Keywords: leave-open
Updated•2 years ago
|
tracking-firefox64:
+ → ---
tracking-firefox65:
--- → +
Comment 7•2 years ago
|
||
Reese, can you please help us get an answer to this bug? We've already had to disable the test once due to these expired probes and this is a decision that we should be able to make in less than 3 months.
Flags: needinfo?(mmorris)
Comment 8•2 years ago
|
||
You may remove the probe and thank you for escalating! Do you need anything else?
Comment 9•2 years ago
|
||
Mike Connor - I made this decision based on the above. If you disagree, speak now or forever hold your peace.
Flags: needinfo?(mmorris)
Comment 10•2 years ago
|
||
(In reply to Marissa Morris from comment #8) > You may remove the probe That's not an option. Either we remove about:searchreset and the probe with it, or we maintain it. Removing half of it doesn't make sense.
Comment 11•2 years ago
|
||
We should just remove the whole thing.
Comment 12•2 years ago
|
||
Ditto what Mike Kaply said, just remove the whole thing and consider this an official approval. :)
Assignee | ||
Comment 14•2 years ago
|
||
Comment 15•2 years ago
|
||
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7c1c64c40df6 Remove about:searchreset. r=mkaply, r=flod
Comment 16•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7c1c64c40df6
Assignee | ||
Comment 17•2 years ago
|
||
All done here
Assignee | ||
Updated•2 years ago
|
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
status-firefox66:
--- → fixed
status-geckoview62:
unaffected → ---
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•