1488948 - browser_abandonment_telemetry.js is going to permafail when the Gecko version number is bumped to 65 on 2018-10-22

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Andreea Pavel [:apavel]]

[Tracking Requested - why for this release]:

Central as Beta simulation

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=701dd8f52ed8236eb93a1bf297ef81997a391170&selectedJob=197614461

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=197614461&repo=try&lineNumber=6051

[task 2018-09-05T14:25:18.754Z] 14:25:18     INFO - TEST-START | browser/base/content/test/tabs/browser_abandonment_telemetry.js
[task 2018-09-05T14:25:18.791Z] 14:25:18     INFO - GECKO(2453) | ++DOMWINDOW == 7 (0xe98f9c00) [pid = 2534] [serial = 7] [outer = 0xe9833700]
[task 2018-09-05T14:25:18.827Z] 14:25:18     INFO - GECKO(2453) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpdxUoKE.mozrunner/runtests_leaks_tab_pid2608.log
[task 2018-09-05T14:25:19.112Z] 14:25:19     INFO - GECKO(2453) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2018-09-05T14:25:19.494Z] 14:25:19     INFO - GECKO(2453) | ++DOCSHELL 0xe974c400 == 1 [pid = 2608] [id = {39b7bdfe-ddb5-464f-94d6-d5c39f826c5e}]
[task 2018-09-05T14:25:19.631Z] 14:25:19     INFO - GECKO(2453) | [Parent 2453, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 1972
[task 2018-09-05T14:25:19.631Z] 14:25:19     INFO - GECKO(2453) | [Parent 2453, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 1972
[task 2018-09-05T14:25:19.696Z] 14:25:19     INFO - GECKO(2453) | ++DOMWINDOW == 1 (0xe970a160) [pid = 2608] [serial = 1] [outer = (nil)]
[task 2018-09-05T14:25:19.946Z] 14:25:19     INFO - GECKO(2453) | ++DOMWINDOW == 2 (0xea436800) [pid = 2608] [serial = 2] [outer = 0xe970a160]
[task 2018-09-05T14:25:20.123Z] 14:25:20     INFO - GECKO(2453) | [Child 2608, Main Thread] WARNING: site security information will not be persisted: file /builds/worker/workspace/build/src/security/manager/ssl/nsSiteSecurityService.cpp, line 553
[task 2018-09-05T14:25:20.265Z] 14:25:20     INFO - GECKO(2453) | [Parent 2453, Main Thread] WARNING: Could not get disk status from nsIDiskSpaceWatcher: file /builds/worker/workspace/build/src/uriloader/prefetch/nsOfflineCacheUpdateService.cpp, line 289
[task 2018-09-05T14:25:20.302Z] 14:25:20     INFO - GECKO(2453) | [Parent 2453, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2088
[task 2018-09-05T14:25:20.303Z] 14:25:20     INFO - GECKO(2453) | [Parent 2453, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2088
[task 2018-09-05T14:25:20.303Z] 14:25:20     INFO - GECKO(2453) | [Parent 2453, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2088
[task 2018-09-05T14:25:20.303Z] 14:25:20     INFO - GECKO(2453) | [Parent 2453, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 2088
[task 2018-09-05T14:25:20.888Z] 14:25:20     INFO - GECKO(2453) | ++DOMWINDOW == 3 (0xe9808800) [pid = 2608] [serial = 3] [outer = 0xe970a160]
[task 2018-09-05T14:25:21.235Z] 14:25:21     INFO - GECKO(2453) | [Parent 2453, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 1972
[task 2018-09-05T14:25:21.235Z] 14:25:21     INFO - GECKO(2453) | [Parent 2453, Main Thread] WARNING: NS_FAILED internal_GetScalarByEnum for CHILD: file /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryScalar.cpp, line 1972
[task 2018-09-05T14:25:21.254Z] 14:25:21     INFO - TEST-INFO | started process screentopng
[task 2018-09-05T14:25:21.880Z] 14:25:21     INFO - TEST-INFO | screentopng: exit 0
[task 2018-09-05T14:25:21.881Z] 14:25:21     INFO - Buffered messages logged at 14:25:18
[task 2018-09-05T14:25:21.881Z] 14:25:21     INFO - Entering test bound test_probes
[task 2018-09-05T14:25:21.881Z] 14:25:21     INFO - Buffered messages logged at 14:25:21
[task 2018-09-05T14:25:21.881Z] 14:25:21     INFO - Test: "Stopping the browser"
[task 2018-09-05T14:25:21.881Z] 14:25:21     INFO - Buffered messages finished
[task 2018-09-05T14:25:21.881Z] 14:25:21     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_abandonment_telemetry.js | Should have seen the stop count increment. - 184 == 1 - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_abandonment_telemetry.js :: assertOnlyOneTypeSet :: line 209
[task 2018-09-05T14:25:21.881Z] 14:25:21     INFO - Stack trace:
[task 2018-09-05T14:25:21.881Z] 14:25:21     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_abandonment_telemetry.js:assertOnlyOneTypeSet:209
[task 2018-09-05T14:25:21.881Z] 14:25:21     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_abandonment_telemetry.js:test_probes/<:281
[task 2018-09-05T14:25:21.882Z] 14:25:21     INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
[task 2018-09-05T14:25:21.882Z] 14:25:21     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_abandonment_telemetry.js:test_probes:264
[task 2018-09-05T14:25:21.883Z] 14:25:21     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
[task 2018-09-05T14:25:21.883Z] 14:25:21     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
[task 2018-09-05T14:25:21.885Z] 14:25:21     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
[task 2018-09-05T14:25:21.885Z] 14:25:21     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-09-05T14:25:21.886Z] 14:25:21     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-09-05T14:25:21.886Z] 14:25:21     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_abandonment_telemetry.js | Should only be 1 collected value. - 346 == 1 - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_abandonment_telemetry.js :: assertOnlyOneTypeSet :: line 213
[task 2018-09-05T14:25:21.887Z] 14:25:21     INFO - Stack trace:
[task 2018-09-05T14:25:21.888Z] 14:25:21     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_abandonment_telemetry.js:assertOnlyOneTypeSet:213
[task 2018-09-05T14:25:21.889Z] 14:25:21     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_abandonment_telemetry.js:test_probes/<:281
[task 2018-09-05T14:25:21.890Z] 14:25:21     INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
[task 2018-09-05T14:25:21.891Z] 14:25:21     INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_abandonment_telemetry.js:test_probes:264
[task 2018-09-05T14:25:21.891Z] 14:25:21     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
[task 2018-09-05T14:25:21.892Z] 14:25:21     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
[task 2018-09-05T14:25:21.893Z] 14:25:21     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
[task 2018-09-05T14:25:21.894Z] 14:25:21     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795

BUSY_TAB_ABANDONED is set to expire in Gecko 65

Comment 1

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Hey digitarald, is the BUSY_TAB_ABANDONED probe still useful to you? We added this back in bug 1307689. If so, I can bump the expiry, and if not I can take it out.

Comment 2

[:Harald Kirschner :digitarald]

Mike, lets keep it around until we have a better probe. It did help with a past experiment in pointing out a page load regression that we would have otherwise missed.

Comment 3

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Attachment: data-review-form

Comment 4

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Attachment: Bug 1488948 - Extend BUSY_TAB_ABANDONED probe until at least 68. data-review=chutten,r?felipe

Comment 5

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Comment on attachment 9007817 [details]
data-review-form

Got a sec to look at this other probe extension, chutten?

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 9007863 [details]
Bug 1488948 - Extend BUSY_TAB_ABANDONED probe until at least 68. data-review=chutten,r?felipe

:Felipe Gomes (needinfo me!) has approved the revision.

Comment 7

[Chris H-C :chutten]

Comment on attachment 9007817 [details]
data-review-form

Preliminary note:

"Nightly and Beta in all countries and locales. Release for users that opt-in to send technical and interaction data to Mozilla in about:preferences. "

This ability to opt in to additional data collection was removed in the Preferences redesign prior to Quantum, so this probe should not be collected on release regardless of user preferences selection.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? 

Yes. Standard Telemetry mechanisms apply.

    Is there a control mechanism that allows the user to turn the data collection on and off? 

Yes. Standard Telemetry mechanisms apply.

    If the request is for permanent data collection, is there someone who will monitor the data over time?**

N/A expires in 68

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2

    Is the data collection request for default-on or default-off?

Default on for prerelease only.

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data? 

Yes. :mconley's responsible for renewing or removing this probe before it expires.

---
Result: datareview+

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22e13c132060
Extend BUSY_TAB_ABANDONED probe until at least 68. data-review=chutten,r=Felipe

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/22e13c132060