Get rid of dom.clearSiteData.enabled pref

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
9 months ago
3 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [domsecurity-backlog1])

Attachments

(2 attachments)

Assignee

Description

9 months ago
ClearSiteData header is now fully supported in firefox. We can get rid of dom.clearSiteData.enabled pref.
Assignee

Comment 1

9 months ago
Attachment #9006729 - Flags: review?(dveditz)
Assignee

Updated

9 months ago
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-backlog1] [domsecurity-active]
Comment on attachment 9006729 [details] [diff] [review]
clearSiteData.patch

Review of attachment 9006729 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is obviously correct, so r=dveditz

Do we want to get rid of the pref so soon? The feature hasn't even made it to Release yet, nor is it used much. The most likely users would be Google because Chrome supports this, and perhaps differently (due to ambiguous specs?). Would be nice to have an "emergency off" switch in our back-pocket for at least a few versions until we're sure our implementation isn't going to lead to our users getting DOS'd. It's not like this patch is killing a bunch of complicated/dangerous code, and leaving it in isn't complicating things.
Attachment #9006729 - Flags: review?(dveditz)
Attachment #9006729 - Flags: review?(ckerschb)
Attachment #9006729 - Flags: review+
Comment on attachment 9006729 [details] [diff] [review]
clearSiteData.patch

Review of attachment 9006729 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should keep that killswitch at least for a few versions. I'll guess we put this patch in the backlog for now and land it after a few cycles.
Attachment #9006729 - Flags: review?(ckerschb) → review-
Priority: -- → P3
Whiteboard: [domsecurity-backlog1] [domsecurity-active] → [domsecurity-backlog1]

Comment 5

3 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c51ea0e79968
Get rid of dom.clearSiteData.enabled pref, r=ckerschb
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.