1488994 - GeckoChildProcessLaunch::AsyncLaunch shouldn't need to wait for CHANNEL_INITIALIZED

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

GeckoChildProcessLaunch::AsyncLaunch does more than launch the process: it also blocks until the I/O thread has initialized the channel.

It doesn't appear that we actually need to do that anymore; the history is old and involves NPAPI, but I made it not do that as part of my async launch patch series, and it passes Try.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Jed Davis [:jld] (⏰UTC-6) from comment #0)
> the history is old and involves NPAPI

For reference, the history is bug 998863.

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1488994 - Stop waiting for channel construction in AsyncLaunch, and clean up launch methods

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 9008596 [details]
Bug 1488994 - Stop waiting for channel construction in AsyncLaunch, and clean up launch methods

Aaron Klotz [:aklotz] has approved the revision.

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 9008596 [details]
Bug 1488994 - Stop waiting for channel construction in AsyncLaunch, and clean up launch methods

Andrew McCreight [:mccr8] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b071d7bc708a
Stop waiting for channel construction in AsyncLaunch, and clean up launch methods r=mccr8,aklotz

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b071d7bc708a