Closed Bug 1488994 Opened 3 years ago Closed 3 years ago

GeckoChildProcessLaunch::AsyncLaunch shouldn't need to wait for CHANNEL_INITIALIZED

Categories

(Core :: IPC, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jld, Assigned: jld)

References

Details

Attachments

(1 file)

GeckoChildProcessLaunch::AsyncLaunch does more than launch the process: it also blocks until the I/O thread has initialized the channel.

It doesn't appear that we actually need to do that anymore; the history is old and involves NPAPI, but I made it not do that as part of my async launch patch series, and it passes Try.
(In reply to Jed Davis [:jld] (⏰UTC-6) from comment #0)
> the history is old and involves NPAPI

For reference, the history is bug 998863.
Comment on attachment 9008596 [details]
Bug 1488994 - Stop waiting for channel construction in AsyncLaunch, and clean up launch methods

Aaron Klotz [:aklotz] has approved the revision.
Attachment #9008596 - Flags: review+
Comment on attachment 9008596 [details]
Bug 1488994 - Stop waiting for channel construction in AsyncLaunch, and clean up launch methods

Andrew McCreight [:mccr8] has approved the revision.
Attachment #9008596 - Flags: review+
Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b071d7bc708a
Stop waiting for channel construction in AsyncLaunch, and clean up launch methods r=mccr8,aklotz
https://hg.mozilla.org/mozilla-central/rev/b071d7bc708a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.