Closed Bug 1489001 Opened 1 year ago Closed 1 year ago

Move most of mozconfig.linux to mozconfig.unix

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Regressed 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

No description provided.
Bug 1487330 made mozconfig.asan use mozconfig.linux, but while that
worked out fine, it turns out that we do have mac builds using
e.g. mozconfig.asan, and that those can break when doing linux-specific
changes to mozconfig.linux.
Attachment #9006756 - Flags: review?(core-build-config-reviews)
Attachment #9006756 - Attachment is obsolete: true
Attachment #9006756 - Flags: review?(core-build-config-reviews)
Attachment #9006757 - Flags: review?(core-build-config-reviews)
Attachment #9006757 - Attachment is obsolete: true
Attachment #9006757 - Flags: review?(core-build-config-reviews)
Attachment #9006761 - Flags: review?(core-build-config-reviews)
Bug 1487330 made mozconfig.asan use mozconfig.linux, but while that
worked out fine, it turns out that we do have mac builds using
e.g. mozconfig.asan, and that those can break when doing linux-specific
changes to mozconfig.linux.
Attachment #9006762 - Attachment is obsolete: true
Comment on attachment 9006761 [details] [diff] [review]
Move most of mozconfig.linux to mozconfig.unix

Review of attachment 9006761 [details] [diff] [review]:
-----------------------------------------------------------------

For those poor souls wondering where the mozconfig.unix part of this is, the diff contains:

diff --git a/build/unix/mozconfig.linux b/build/unix/mozconfig.unix
similarity index 100%
copy from build/unix/mozconfig.linux
copy to build/unix/mozconfig.unix
Attachment #9006761 - Flags: review?(core-build-config-reviews) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f0491b762dd
Move most of mozconfig.linux to mozconfig.unix. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/2f0491b762dd
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Regressions: 1584425
No longer regressions: 1584425
Regressions: 1573135
You need to log in before you can comment on or make changes to this bug.