Closed Bug 1489021 Opened 2 years ago Closed 2 years ago

Move Throbber-small.gif to toolkit/crashreporter/client

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

No description provided.
I was there, looking at a Firefox directory in my file manager while
working on bug 1079662, when I noticed the `Throbber-small.gif`
appearing first in the list, and wondering where it came from. And I
found it's there for the crashreporter UI. Fair enough.

But back when it was added in bug 404855, the file was also used for
Firefox, which is why it's taken from the Firefox theme. Interestingly,
back then, the file was duplicated in multiple themes, but was taken
from the windows theme rather than the gnome theme. Figures.

Anyways, later down the road, in bug 421595, Firefox replaced the gif
throbber with an APNG version. Then even later, bug 418003 removed the
unused gif throbber files, leaving the Windows one alone because it's
used by the crashreporter client moz.build (Makefile, back then), but
still removed the reference from the jar.mn.

9 years later, here we are, still using a file from the Windows theme,
that is not actually part of the Windows theme, for the Linux
crashreporter.
Attachment #9006777 - Flags: review?(core-build-config-reviews)
Comment on attachment 9006777 [details] [diff] [review]
Move Throbber-small.gif to toolkit/crashreporter/client

Review of attachment 9006777 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the very entertaining commit message -- that's why I subscribe to this newsletter.
Attachment #9006777 - Flags: review?(core-build-config-reviews) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc562d7babca
Move Throbber-small.gif to toolkit/crashreporter/client. r=nalexander
https://hg.mozilla.org/mozilla-central/rev/fc562d7babca
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.