WebRTC ICE candidate stats ipAddress needs to be renamed

RESOLVED FIXED in Firefox 65

Status

()

P3
normal
Rank:
25
RESOLVED FIXED
7 months ago
3 months ago

People

(Reporter: ng, Assigned: ng)

Tracking

(Blocks: 1 bug, {dev-doc-complete, site-compat})

unspecified
mozilla65
dev-doc-complete, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

It looks like the spec [0] is moving towards[1] the name 'address' instead of 'ip'. Either way things shake out we will need to rename 'ipAddress'[2].

[0] https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-ip
[1] https://github.com/w3c/webrtc-pc/issues/1913 *
[2] https://searchfox.org/mozilla-central/source/dom/webidl/RTCStatsReport.webidl#156

*Note the spec issue is filed against the webrtc-pc not webrtc-stats spec, but mentions the need to mirror the change in the webrtc-stats spec.
Status: NEW → ASSIGNED
Rank: 25
Priority: -- → P3
Keywords: dev-doc-needed
Bug 1489040 - P1 - Update WebRTC ICE candidate stats field ipAddress to new name, address
Bug 1489040 - P2 - ajust WebRTC stats mochitest for new stat name 'address'
Bug 1489040 - P3 - add test for legacy WebRTC stat names
Comment on attachment 9008126 [details]
Bug 1489040 Update WebRTC ICE candidate stats field name ipAddress to address

Jan-Ivar Bruaroey [:jib] (needinfo? me) has approved the revision.
Attachment #9008126 - Flags: review+
Comment on attachment 9008126 [details]
Bug 1489040 Update WebRTC ICE candidate stats field name ipAddress to address

Michael Froman [:mjf] has approved the revision.
Attachment #9008126 - Flags: review+
Blocks: 1324788

Comment 12

4 months ago
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/68d20ffd470d
Update WebRTC ICE candidate stats field name ipAddress to address r=mjf,jib,smaug

Comment 13

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/68d20ffd470d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Note to MDN writers:

This is covered in the rel notes under the general note about 
RTCIceCandidateStats; see
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#APIs

I'm setting this to dev-doc-complete, because the other related bug (1324788) will cover this when the documentation is done.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.