1489040 - WebRTC ICE candidate stats ipAddress needs to be renamed

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P3)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

It looks like the spec [0] is moving towards[1] the name 'address' instead of 'ip'. Either way things shake out we will need to rename 'ipAddress'[2].

[0] https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-ip
[1] https://github.com/w3c/webrtc-pc/issues/1913 *
[2] https://searchfox.org/mozilla-central/source/dom/webidl/RTCStatsReport.webidl#156

*Note the spec issue is filed against the webrtc-pc not webrtc-stats spec, but mentions the need to mirror the change in the webrtc-stats spec.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d083a377764c4409e1a06f80fa68549deefe00d

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4443f2ee1c51cc54b77eb1ba56b57579bd74f31

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1489040 Update WebRTC ICE candidate stats field name ipAddress to address

Bug 1489040 - P1 - Update WebRTC ICE candidate stats field ipAddress to new name, address
Bug 1489040 - P2 - ajust WebRTC stats mochitest for new stat name 'address'
Bug 1489040 - P3 - add test for legacy WebRTC stat names

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41107083a95a22eaf52385fca6c44108ee8b03f5

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b93ebdebffe6c888f497fc757932fa9d524534f7

Comment 6

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=956b5e9fcc605a0e3ceb08aba9cabf119f83a954

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 9008126 [details]
Bug 1489040 Update WebRTC ICE candidate stats field name ipAddress to address

Jan-Ivar Bruaroey [:jib] (needinfo? me) has approved the revision.

Comment 8

[Michael Froman [:mjf]]

Comment on attachment 9008126 [details]
Bug 1489040 Update WebRTC ICE candidate stats field name ipAddress to address

Michael Froman [:mjf] has approved the revision.

Comment 9

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5795010a4a5ee776a1d1e8a0e69a8515503a3513

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Spec Links for WebIDL review:
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-address

Comment 11

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8ce4c69c850c5925e701ac8e5b3effaeb6fbd66

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68d20ffd470d
Update WebRTC ICE candidate stats field name ipAddress to address r=mjf,jib,smaug

Comment 13

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/68d20ffd470d

Comment 14

[Kohei Yoshino]

Posted site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/rtcicecandidatestats-has-been-updated-to-the-latest-spec/

Comment 15

[Chris Mills [:cmills]]

Note to MDN writers:

This is covered in the rel notes under the general note about 
RTCIceCandidateStats; see
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#APIs

I'm setting this to dev-doc-complete, because the other related bug (1324788) will cover this when the documentation is done.