1489081 - Remove now unnecessary files in FFmpeg's ffvpx tree

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Jean-Yves Avenard [:jya]]

Due to the pgo builds worked on Windows, we had to fake non-used code in instances like:

if (0) {
  function_call();
}

Where all compilers would optimise out function_call() The Microsoft compiler insisted to see it.

As such, we created libav{codec,util}/dummy_funcs.c which contains methods, structures otherwise unused, just to make the compiler happy.

With the move to clang-cl as default compiler, those are no longer necessary.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1489081 - Remove no longer necessary files. r?bryce

With the move to clang-cl as default compiler on Windows, those are no longer necessary.

Comment 2

[(Away)]

Clang is now the default, yes, but it's not yet the only compiler. MSVC builds still need to be kept green, and that's still enforced by tier-2 jobs running on m-c. Nobody has really discussed timelines yet, but I don't expect that we'll drop MSVC until at least clang reaches the release channel.

Comment 3

[Jean-Yves Avenard [:jya]]

But do we do pgo build on those tier-2 jobs?

Comment 4

[(Away)]

Yes, we do. The idea is that we need to be able to flip the switch back to MSVC for our official builds (i.e. PGO) if there is any unforeseen disaster with the clang release.

Comment 5

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9006828 [details]
Bug 1489081 - Remove no longer necessary files. r?bryce

Bryce Seager van Dyk (:bryce) has approved the revision.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jya, could you have a look please?

Comment 7

[Jean-Yves Avenard [:jya]]

Now MSVC support has been removed, can I push this now?

Comment 8

[(Away)]

Please do!

You may want to adjust this comment too: https://searchfox.org/mozilla-central/rev/a7315d78417179b151fef6108f2bce14786ba64d/media/ffvpx/README_MOZILLA#36

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/576713616fbb
Remove no longer necessary files. r=bryce

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/576713616fbb

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/feddf40d27f3
followup: remove the now-outdated comment. DONTBUILD

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/feddf40d27f3