Closed Bug 1489098 Opened Last year Closed Last year

Remove useless use of PromiseFlatString

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

Details

Attachments

(1 file)

PromiseFlatString(value).get()
should be
value.BeginReading()

(Or GetDirectionFromText() could be refactored to take a Span.)
Morphing to a more general bug.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Component: Internationalization → String
Summary: Useless use of PromiseFlatString in SetDirectionalityFromValue → Remove useless use of PromiseFlatString
(I found these while I was checking if we have more bugs like bug 1488452.)
Useless use of PromiseFlatCString tends to be more complex. (Forgetting the string length in one function and recomputing it in another.) That problem is so vast is doesn't make sense to try to deal with it here.
Priority: -- → P3
I checked PromiseFlatCString usage for the problem seen in bug 1488452 and, fortunately, didn't find any. Bug 1488452 looks like a unique misuse of PromiseFlatString.
MozReview-Commit-ID: 10JE4PRp8i0
Comment on attachment 9007146 [details]
Bug 1489098 - Remove useless use of PromiseFlatString.

Peter Van der Beken [:peterv] has approved the revision.
Attachment #9007146 - Flags: review+
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea41800d0ae0
Remove useless use of PromiseFlatString. r=peterv
https://hg.mozilla.org/mozilla-central/rev/ea41800d0ae0
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.