1489098 - Remove useless use of PromiseFlatString

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Henri Sivonen (:hsivonen)]

PromiseFlatString(value).get()
should be
value.BeginReading()

(Or GetDirectionFromText() could be refactored to take a Span.)

Comment 1

[Henri Sivonen (:hsivonen)]

Morphing to a more general bug.

Comment 2

[Henri Sivonen (:hsivonen)]

(I found these while I was checking if we have more bugs like bug 1488452.)

Comment 3

[Henri Sivonen (:hsivonen)]

Useless use of PromiseFlatCString tends to be more complex. (Forgetting the string length in one function and recomputing it in another.) That problem is so vast is doesn't make sense to try to deal with it here.

Comment 4

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e636c73b6ed286d1383fc85a71255b5102fc98f

Comment 5

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2f5feff9263eb559f23c791c6eff27d190d3528

All of these are under dom/.

Comment 6

[Henri Sivonen (:hsivonen)]

I checked PromiseFlatCString usage for the problem seen in bug 1488452 and, fortunately, didn't find any. Bug 1488452 looks like a unique misuse of PromiseFlatString.

Comment 7

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1489098 - Remove useless use of PromiseFlatString.

MozReview-Commit-ID: 10JE4PRp8i0

Comment 8

[Peter Van der Beken [:peterv]]

Comment on attachment 9007146 [details]
Bug 1489098 - Remove useless use of PromiseFlatString.

Peter Van der Beken [:peterv] has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea41800d0ae0
Remove useless use of PromiseFlatString. r=peterv

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ea41800d0ae0