Closed Bug 1489132 Opened Last year Closed Last year

Cannot upload geckoview beta: version number doesn't match 63.0bX

Categories

(Release Engineering :: Release Automation: Uploading, enhancement)

enhancement
Not set

Tracking

(geckoview62 wontfix, firefox-esr60 wontfix, firefox62 wontfix, firefox63 fixed, firefox64 fixed)

RESOLVED FIXED
Tracking Status
geckoview62 --- wontfix
firefox-esr60 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: jlorenzo, Assigned: jlorenzo)

References

Details

Attachments

(3 files)

Geckoview 63.0b3 should have been the first beta uploaded to maven.mozilla.org. Sadly, it was stuck in beetmover, because the latter didn't expect the version number to be 63.0.20180904170936[1]

It seems this condition[2] didn't work under beta. Even if it worked, we would have ended up with 63.0[3] instead of 63.0b4. Therefore, changing the version to 63.0bX is a non-trivial task. I'm tempted to make all geckoview versions from all branches (namely beta and release) comply to the scheme MAJOR.MINOR.BUILDID.

Release should be changed because of a different type of problem. The Geckoview team uses RELBRANCHES (on mozilla-release) to craft new geckoview releases. If we wanted to go with MAJOR.MINOR.PATCH, then we would have to store what's the PATCH number somewhere. In the case of Fennec, this is done in tree[5]. If we wanted to implement the same mechanism, we would have to implement a bump task that only works on the RELBRANCH.

Over IRC, Sebastian said it's okay to use MAJOR.MINOR.BUILDID for now.



[1] https://tools.taskcluster.net/groups/KxUUhrkjTP2SdymRS_Si9w/tasks/abIq6aPsQbm_PmnEr59fXw/runs/0/logs/public%2Flogs%2Flive_backing.log
[2] https://searchfox.org/mozilla-central/rev/a41fd8cb947266ea2e3f463fc6e31c88bfab9d41/mobile/android/geckoview/build.gradle#299
[3] https://tools.taskcluster.net/groups/VTZ3dnoqT56a5j--_uTmpQ/tasks/P1-VZTNaRwCNQSVtoz4nVg/runs/0/logs/public%2Flogs%2Flive_backing.log#L33318
[4] https://hg.mozilla.org/releases/mozilla-release/shortlog/GECKOVIEW_62_RELBRANCH
[5] https://hg.mozilla.org/releases/mozilla-release/file/tip/browser/config/version_display.txt
Attached file [beetmoverscript] PR
Assignee: nobody → jlorenzo
Attachment #9007214 - Flags: review?(mtabara)
Attachment #9007214 - Flags: review?(mtabara) → review+
Attachment #9007220 - Flags: review?(mtabara) → review+
Comment on attachment 9007220 [details] [review]
[build/puppet] Bump beetmoverscript to 7.9.1

Landed on master at: https://github.com/mozilla-releng/build-puppet/commit/9f6de74e8d8b6cac20daa9ea976670fe97957deb
Attachment #9007220 - Flags: checked-in+
Ensure geckoview build numbers are always MAJOR.MINOR.BUILDID
Comment on attachment 9007300 [details]
Bug 1489132 - Ensure geckoview build numbers are always MAJOR.MINOR.BUILDID r=sebastian,jchen

Jim Chen [:jchen] [:darchons] has approved the revision.
Attachment #9007300 - Flags: review+
Comment on attachment 9007300 [details]
Bug 1489132 - Ensure geckoview build numbers are always MAJOR.MINOR.BUILDID r=sebastian,jchen

Sebastian Kaspari (:sebastian) has approved the revision.
Attachment #9007300 - Flags: review+
Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/288a2128adc5
Ensure geckoview build numbers are always MAJOR.MINOR.BUILDID r=sebastian,jchen
https://hg.mozilla.org/mozilla-central/rev/288a2128adc5
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.