Closed Bug 1489207 Opened Last year Closed Last year

Update 7zSD.sfx to keep current with Firefox

Categories

(Thunderbird :: Installer, enhancement)

Desktop
Windows
enhancement
Not set

Tracking

(thunderbird_esr6062+ fixed, thunderbird63 fixed, thunderbird64 fixed)

RESOLVED FIXED
Thunderbird 64.0
Tracking Status
thunderbird_esr60 62+ fixed
thunderbird63 --- fixed
thunderbird64 --- fixed

People

(Reporter: rjl, Assigned: Paenglab)

Details

Attachments

(5 files)

Followup to bug 1486376.

Now that binary SFX stub (7zSD.sfx) for the Windows installer has been updated to use the LZMA SDK rather than the RAR-code tainted 7zip source code, we need to update the copy of it in C-C so that the binaries we distribute match the installers we ship. The stub we currently use was last updated in Bug 1361326, and the built version doesn't match the source code we ship for it.

From what I can tell, up until somewhere around Bug 1365998, the stub was just a copy of what was being used in Firefox. That bug introduced among other things a custom icon based on the Firefox logo, so a straight copy wouldn't be suitable anymore. I looked at the most recent installers we have shipped, and the icon is just some generic thing, likely the default from 7zip.

At a minimum we need to get an updated stub file. Ideally, we learn how to build one ourselves. Based on the readme file distributed with the source.
Attached image setup.ico
Created a TB installer icon based on the FX icon.
Patch with the FX sfx file but  with the TB installer icon with a resource hacker tool exchanged.

I can try it when the installer packaging works again.
Assignee: nobody → richard.marti
Comment on attachment 9007348 [details] [diff] [review]
InstallerUpdate.patch

Yep, it works.

Jörg, as I wrote already, I exchanged the icon of the FX SFX file with the "Resource Hacker" tool. Like this, the file is the same except the icon.
Attachment #9007348 - Flags: review?(jorgk)
Comment on attachment 9007348 [details] [diff] [review]
InstallerUpdate.patch

Excellent work! Thanks to reporter and assignee. I've checked the icon and I've unpacked 7zSD.sfx with 7zip to check the content, also with the tool (http://www.angusj.com/resourcehacker/).

Looks like bug 1486376 in ESR 60, so we should uplift this, too? Please correct me if I'm wrong on this.
Attachment #9007348 - Flags: review?(jorgk)
Attachment #9007348 - Flags: review+
Attachment #9007348 - Flags: approval-comm-esr60+
Attachment #9007348 - Flags: approval-comm-beta+
I think yes. Bug 1413568 landed in 55, bug 1436475 in 60. But bug 1425468 landed in 62 and the following bug 1486376 had a special ESR patch. I could take the SFX of this bug and exchange the icon, what do you think?
Keywords: checkin-needed
Patch with the FX-ESR SFX patched.
Attachment #9007585 - Flags: review+
Attachment #9007585 - Flags: approval-comm-esr60?
Attachment #9007348 - Flags: approval-comm-esr60+
Comment on attachment 9007585 [details] [diff] [review]
InstallerUpdate-ESR.patch

OK, so FF's ESR 60 file was different to start with, yes?
Attachment #9007585 - Flags: approval-comm-esr60? → approval-comm-esr60+
Yes, I compared them and they are different.
TB 60.1 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/895f4accbdb6da4b0ac1bcf159b0b471e46e686d

Landed the ESR part now. We need to check that it's working. I don't understand the "installer packaging works again". Is that waiting for bug 1489355? Isn't the installer simply the target.installer.exe from the "B" job. That's working now and that's what the try in comment #9 has. Or is something required from the currently-broken "Nr" job?
Target Milestone: --- → Thunderbird 64.0
Sorry, ... that's what the try in comment #5 has.
(In reply to Jorg K (GMT+2) from comment #12)
> 
> Landed the ESR part now. We need to check that it's working. I don't
> understand the "installer packaging works again". Is that waiting for bug
> 1489355? Isn't the installer simply the target.installer.exe from the "B"
> job. That's working now and that's what the try in comment #9 has. Or is
> something required from the currently-broken "Nr" job?

I'd could be wrong when I thought it depends on bug 1489355 to package. It landed and Daily is updating again.
Well, you tested with the "B" from your try. So here's a try for ESR 60:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=f149f95b51effaf8d0cef973f0c736d90da69ccd
Can you please check it when it's done.
Installer looks good.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fe142027bfff
Update 7zSD.sfx with Thunderbird icon to keep up-to-date with Firefox. r=jorgk
Status: NEW → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
The installer that gets shipped is from the Nr repackage job. IIRC, target.instsller.exe gets compressed with UPX, and then gets mangled together with the .sfx stub and maybe some other bits.

The Seamonkey folks should probably make the same updates to their installer.
(In reply to Rob Lemley [:rjl] from comment #0)
> Ideally, we learn how to
> build one ourselves. Based on the readme file distributed with the source.

7zstub has to be built with MSVC 6.0 for maximum compatibility with older versions of Windows. Even though Gecko no longer supports Windows Vista or earlier, installers must show a user-friendly message instead of a cryptic "Thunderbird Setup *.exe is not a valid Win32 application."

Does anyone in Thunderbird team have MSVC 6?
You need to log in before you can comment on or make changes to this bug.