Closed
Bug 1489219
Opened 6 years ago
Closed 6 years ago
[remote-dbg-next] Tests: Add a basic mochitest for This Firefox
Categories
(DevTools :: about:debugging, enhancement, P1)
DevTools
about:debugging
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(3 files)
We should add a test that asserts that page is displayed, contains runtime info and debug targets. Interactions with debug targets should be done in more specific tests.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Ran this new test through try https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=198026268&revision=34beed9bf8a0064637d0e94854ecf158fadb5532
Looks like either the test or the UI is leaking, as all the debug runs report as such. Will investigate.
|
|
Assignee | |
Comment 3•6 years ago
|
||
Depends on D5250
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
|
Assignee | |
Comment 6•6 years ago
|
||
wrong link. correct try push: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=198125857&revision=468a1b0273d8ea1d8b95fd9626e0418ce1a7b4da (already green on some debug dt jobs including the new test)
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9007263 [details]
Bug 1489219 - Wait until runtime page is ready;r=daisuke,ladybenko
Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #9007263 -
Flags: review+
|
|
||
Comment 8•6 years ago
|
||
Comment on attachment 9007265 [details]
Bug 1489219 - Cleanup all listeners on aboutdebugging unload;r=daisuke,ladybenko
Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #9007265 -
Flags: review+
|
||
Comment 9•6 years ago
|
||
Comment on attachment 9007184 [details]
Bug 1489219 - Add basic mochitest for This Firefox page;r=daisuke,ladybenko
Belén [:ladybenko] has approved the revision.
Attachment #9007184 -
Flags: review+
|
|
||
Comment 10•6 years ago
|
||
Comment on attachment 9007263 [details]
Bug 1489219 - Wait until runtime page is ready;r=daisuke,ladybenko
Belén [:ladybenko] has approved the revision.
Attachment #9007263 -
Flags: review+
|
|
||
Comment 11•6 years ago
|
||
Comment on attachment 9007184 [details]
Bug 1489219 - Add basic mochitest for This Firefox page;r=daisuke,ladybenko
Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #9007184 -
Flags: review+
|
|
||
Comment 12•6 years ago
|
||
Comment on attachment 9007265 [details]
Bug 1489219 - Cleanup all listeners on aboutdebugging unload;r=daisuke,ladybenko
Belén [:ladybenko] has approved the revision.
Attachment #9007265 -
Flags: review+
|
||
Comment 13•6 years ago
|
||
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de44388ab387
Cleanup all listeners on aboutdebugging unload;r=daisuke,ladybenko
https://hg.mozilla.org/integration/mozilla-inbound/rev/77fdbbe9e2df
Add basic mochitest for This Firefox page;r=daisuke,ladybenko
https://hg.mozilla.org/integration/mozilla-inbound/rev/483b0f400100
Wait until runtime page is ready;r=daisuke,ladybenko
|
||
Comment 14•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/de44388ab387
https://hg.mozilla.org/mozilla-central/rev/77fdbbe9e2df
https://hg.mozilla.org/mozilla-central/rev/483b0f400100
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
|
||
Updated•6 years ago
|
Priority: P3 → P1
You need to log in
before you can comment on or make changes to this bug.
Description
•