Port Bug 1488084 "TypeError: getBrowser(...) is null - mailWindow.js:62:19" to SeaMonkey

RESOLVED FIXED in Future

Status

defect
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: frg, Assigned: frg)

Tracking

unspecified
Future

SeaMonkey Tracking Flags

(seamonkey2.49esr fixed, seamonkey2.53 affected, seamonkey2.57esr fixed, seamonkey2.60 wontfix)

Details

Attachments

(2 attachments)

Assignee

Description

9 months ago
+++ This bug was initially created as a clone of Bug #1488084 +++

onCopyOrDragStart chrome://messenger/content/mailWindow.js:62:19

STR:
Display the calendar tab. Click and drag (accidentally) on the Day, Week, Multiweek or Month label.
Assignee

Comment 1

9 months ago
1:1 patch. Should apply clean to all trees.
Attachment #9007062 - Flags: review?(iann_bugzilla)
Attachment #9007062 - Flags: approval-comm-esr60?
Attachment #9007062 - Flags: approval-comm-esr52?

Comment 2

9 months ago
Comment on attachment 9007062 [details] [diff] [review]
1489302-dragdrop.patch

Very straight forward r/a=me
Attachment #9007062 - Flags: review?(iann_bugzilla)
Attachment #9007062 - Flags: review+
Attachment #9007062 - Flags: approval-comm-esr60?
Attachment #9007062 - Flags: approval-comm-esr60+
Attachment #9007062 - Flags: approval-comm-esr52?
Attachment #9007062 - Flags: approval-comm-esr52+

Comment 3

9 months ago
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/736f858f44ce
Port Bug 1488084 [fix TypeError: getBrowser() is null in mailWindow.js] to SeaMonkey. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Assignee

Comment 5

9 months ago
Unfortunately this caused a regression so a follow-up is needed. See original Bug 1488084 for the details.
Attachment #9009429 - Flags: review?(iann_bugzilla)
Attachment #9009429 - Flags: approval-comm-esr60?
Attachment #9009429 - Flags: approval-comm-esr52?

Comment 6

9 months ago
Comment on attachment 9009429 [details] [diff] [review]
1489302-2.patch

r/a=me
Attachment #9009429 - Flags: review?(iann_bugzilla)
Attachment #9009429 - Flags: review+
Attachment #9009429 - Flags: approval-comm-esr60?
Attachment #9009429 - Flags: approval-comm-esr60+
Attachment #9009429 - Flags: approval-comm-esr52?
Attachment #9009429 - Flags: approval-comm-esr52+

Comment 7

9 months ago
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/553c535bc354
Follow-up from Bug 1488084. Restore accidentally removed sourceDoc. r=IanN

Comment 9

9 months ago
Oh boy, you ported that with the error and neither you nor Ian spotted the mistake :-( - It needed Mark from Pale Moon to tell us.
Assignee

Comment 10

9 months ago
Well I did trust you and IanN probably me (despite unintentionally smuggling in another whitespace error). Did only test that the error did go away. Happend to me too so I wouldn't loose much sleep over it. That is what test builds (in this case Bills until our infra is ready) are for.
You need to log in before you can comment on or make changes to this bug.