Closed
Bug 1489302
Opened 6 years ago
Closed 6 years ago
Port Bug 1488084 "TypeError: getBrowser(...) is null - mailWindow.js:62:19" to SeaMonkey
Categories
(SeaMonkey :: MailNews: General, defect)
SeaMonkey
MailNews: General
Tracking
(seamonkey2.49esr fixed, seamonkey2.60 wontfix, seamonkey2.53 affected, seamonkey2.57esr fixed)
RESOLVED
FIXED
Future
People
(Reporter: frg, Assigned: frg)
Details
Attachments
(2 files)
|
1.10 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-esr52+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
1.20 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-esr52+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1488084 +++ onCopyOrDragStart chrome://messenger/content/mailWindow.js:62:19 STR: Display the calendar tab. Click and drag (accidentally) on the Day, Week, Multiweek or Month label.
|
Assignee | |
Comment 1•6 years ago
|
||
1:1 patch. Should apply clean to all trees.
Attachment #9007062 -
Flags: review?(iann_bugzilla)
Attachment #9007062 -
Flags: approval-comm-esr60?
Attachment #9007062 -
Flags: approval-comm-esr52?
Comment on attachment 9007062 [details] [diff] [review] 1489302-dragdrop.patch Very straight forward r/a=me
Attachment #9007062 -
Flags: review?(iann_bugzilla)
Attachment #9007062 -
Flags: review+
Attachment #9007062 -
Flags: approval-comm-esr60?
Attachment #9007062 -
Flags: approval-comm-esr60+
Attachment #9007062 -
Flags: approval-comm-esr52?
Attachment #9007062 -
Flags: approval-comm-esr52+
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/736f858f44ce Port Bug 1488084 [fix TypeError: getBrowser() is null in mailWindow.js] to SeaMonkey. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•6 years ago
|
||
https://hg.mozilla.org/releases/comm-esr60/rev/654ec73607bfff64e3320a8acdeb0b5c7ad67ed6 https://hg.mozilla.org/releases/comm-esr52/rev/0b6424ff09a7b688e7935e220aa930ffd0835287
Target Milestone: --- → Future
|
|
Assignee | |
Comment 5•6 years ago
|
||
Unfortunately this caused a regression so a follow-up is needed. See original Bug 1488084 for the details.
Attachment #9009429 -
Flags: review?(iann_bugzilla)
Attachment #9009429 -
Flags: approval-comm-esr60?
Attachment #9009429 -
Flags: approval-comm-esr52?
Comment on attachment 9009429 [details] [diff] [review] 1489302-2.patch r/a=me
Attachment #9009429 -
Flags: review?(iann_bugzilla)
Attachment #9009429 -
Flags: review+
Attachment #9009429 -
Flags: approval-comm-esr60?
Attachment #9009429 -
Flags: approval-comm-esr60+
Attachment #9009429 -
Flags: approval-comm-esr52?
Attachment #9009429 -
Flags: approval-comm-esr52+
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/553c535bc354 Follow-up from Bug 1488084. Restore accidentally removed sourceDoc. r=IanN
|
|
Assignee | |
Comment 8•6 years ago
|
||
https://hg.mozilla.org/releases/comm-esr60/rev/72a8163cc7ea4050cdfdcc725c1b96edc002d364 https://hg.mozilla.org/releases/comm-esr52/rev/6b4a44972c3b4276a6adcfcce3732ef6247d5ce9 Follow-up from Bug 1488084. Restore accidentally removed sourceDoc. r=IanN
|
||
Comment 9•6 years ago
|
||
Oh boy, you ported that with the error and neither you nor Ian spotted the mistake :-( - It needed Mark from Pale Moon to tell us.
|
|
Assignee | |
Comment 10•6 years ago
|
||
Well I did trust you and IanN probably me (despite unintentionally smuggling in another whitespace error). Did only test that the error did go away. Happend to me too so I wouldn't loose much sleep over it. That is what test builds (in this case Bills until our infra is ready) are for.
You need to log in
before you can comment on or make changes to this bug.
Description
•