Open Bug 1489313 Opened 3 years ago Updated 3 years ago

Explicitly unravel parts of the realm when top level document is unloaded and it is in a tabgroup containing only one entry and the new page to be loaded is from different origin

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: smaug, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 5 obsolete files)

Breaking down documents explicitly could reduce time spent in collectors later.
After hueyfix has run, we could explicitly remove all the event listeners, clear wrappers, break down document.
The key thing which helps here,  as far as I see, is tabgroup having just one item. Then there is no need to look at edges coming from other windows/tabs.
Er, tabgroup should have only one top level entry.
Priority: -- → P3
A simple idea.
Attached patch realm_tracing.diff (obsolete) — Splinter Review
Way scarier approach, but also, if this works, way more effective.


remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/5a9391a84eb9e83c988df690601c558ec4e3c342
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a9391a84eb9e83c988df690601c558ec4e3c342
remote: 
remote: It looks like this try push has talos jobs. Compare performance against a baseline revision:
remote:   https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=5a9391a84eb9e83c988df690601c558ec4e3c342
remote: recorded changegroup in replication log in 0.014s
Summary: Explicitly unravel document trees when top level document is unloaded and it is in a tabgroup containing only one entry and the new page to be loaded is from different origin → Explicitly unravel parts of the realm when top level document is unloaded and it is in a tabgroup containing only one entry and the new page to be loaded is from different origin
Attached patch realm_tracing_2.diff (obsolete) — Splinter Review
unbarriered value reading.
emote: View your change here:
remote:   https://hg.mozilla.org/try/rev/0067215b55b10bb1c7b70bf2fca454603de3e8fb
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=0067215b55b10bb1c7b70bf2fca454603de3e8fb
remote: 
remote: It looks like this try push has talos jobs. Compare performance against a baseline revision:
remote:   https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=0067215b55b10bb1c7b70bf2fca454603de3e8fb
remote: recorded changegroup in replication log in 0.016s
Attached patch realm_tracing_3.diff (obsolete) — Splinter Review
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/09225ebf48c4975fbee67bda5fbb05d7ed504537
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=09225ebf48c4975fbee67bda5fbb05d7ed504537
remote: recorded changegroup in replication log in 0.016s
Attachment #9008055 - Attachment is obsolete: true
Attachment #9008079 - Attachment is obsolete: true
Attached patch realm_tracing_4.diff (obsolete) — Splinter Review
Attachment #9008213 - Attachment is obsolete: true
Attached patch realm_tracing_5.diff (obsolete) — Splinter Review
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=11da9ece0c5b38f8202bc327323a9c760aeb666b
remote: recorded changegroup in replication log in 0.016s
Attachment #9008518 - Attachment is obsolete: true
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/898bc1d5576282920f5bcfcc9438a5d99c0cd031
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=898bc1d5576282920f5bcfcc9438a5d99c0cd031
remote: recorded changegroup in replication log in 0.023s
Attachment #9008521 - Attachment is obsolete: true
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=191a1805a51f5b9e1757d19352305a3f55372c92
remote: recorded changegroup in replication log in 0.016s
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.