148933 - "Info" window for Bookmarks and Folders

Status: VERIFIED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

This bug is for the implementation of an Info window for bookmarks, 
bookmark folders and bookmark groups, that allows editing of the 
bookmark name, location, keyword and description, per http://
www.mozilla.org/quality/browser/front-end/testcases/bookmarks/view-
properties.html

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

A basic bookmark info window has been checked in. It could use some polish
(resizing when elements are hidden), but functionally works and users can now
edit name, url, keyword and description via this method. 

Comment 2

[Winnie Lam]

Verified using 06-06 build.  OS 10.1.4.  I can edit bookmark properties (rename,
change URL etc.) in my sidebar by right-clicking on the bookmark and selecting
"Get info".  

I noticed that if I change the URL of a bookmark, accessing that bookmark
through the sidebar or the Bookmarks menu takes me to the new URL.

However, if I rename a bookmark, that bookmark only gets renamed in the sidebar
and not in the Bookmarks menu.

reopening this bug (or i could file a separate bug for this...)

Comment 3

[Steve Smart]

Fixed OS

Comment 4

[sairuh (rarely reading bugmail)]

also --shouldn't there be cancel/ok buttons on this window? not sure what the ui
guidelines would be there, although cmd+w closes the window, which is good.

Comment 5

[sairuh (rarely reading bugmail)]

side note to comment 2 where editing the name doesn't show up in the bookmarks
menu: i also see this, but it does show up after quitting and restarting.

Comment 6

[David Haas (gone, not reading mail)]

patch for bug 158378 changes this from a panel to a dialog - and adds OK &
Cancel buttons.  Still doesn't resize when elements are hidden. Sorry.

Also, from comments 2 & 5: this was bug 155560 which is fixed.

When bug 158378 lands, I think this should be closed. Let other bugs handle
specific problems with this dialog.

Comment 7

[Max Horn]

What prevents this bug from being closed?

BTW I don't think that adding OK/Cancel buttons to a "Get Info" style panel would be a 
good idea. It's meant to be instant acting. The proper way to recover from accidental 
changes should be via Undo/Redo.

Comment 8

[David Haas (gone, not reading mail)]

This has been fixed for awhile.  Other bugs can handle specific implementation
problems.  

Comment 9

[Winnie Lam]

verified.  get info window works.  renaming bookmark title (per comment #2) in
get info window takes effect in menu item immediately.  08-15 build on OS 10.1.5.