Closed Bug 1489355 Opened Last year Closed Last year

Building Windows installer fails

Categories

(Thunderbird :: Installer, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(1 file)

Building the Windows installer fails in the repackage task.

https://treeherder.mozilla.org/logviewer.html#?job_id=197898813&repo=try-comm-central&lineNumber=1993

18:58:59     INFO - Running command: ['c:\\mozilla-build\\python\\python.exe', 'mach', '--log-no-times', 'repackage', u'installer', u'--package-name', u'firefox', u'--tag', u'comm/mail/installer/windows/app.tag', u'--sfx-stub', u'comm/other-licenses/7zstub/thunderbird/7zSD.sfx', '--setupexe', u'Z:\\task_1536259302\\fetches\\setup.exe', '--package', u'Z:\\task_1536259302\\fetches\\target.zip', '--output', u'z:\\task_1536259302\\build\\outputs\\target.installer.exe'] in z:\task_1536259302\build\src
18:59:01     INFO -  Error running mach:
18:59:01     INFO -  The details of the failure are as follows:
18:59:01     INFO -  IOError: [Errno 2] No such file or directory: 'core'
18:59:01     INFO -    File "z:\task_1536259302\build\src\python/mozbuild/mozbuild/mach_commands.py", line 2719, in repackage_installer
18:59:01     INFO -      sfx_stub=sfx_stub,
18:59:01     INFO -    File "z:\task_1536259302\build\src\python/mozbuild\mozbuild\repackaging\installer.py", line 45, in repackage_installer
18:59:01     INFO -      archive_exe(package_name, tag, sfx_package, output)
18:59:01     INFO -    File "z:\task_1536259302\build\src\python/mozbuild\mozbuild\action\exe_7z_archive.py", line 36, in archive_exe
18:59:01     INFO -      shutil.move('core', pkg_dir)
18:59:01     INFO -    File "c:\mozilla-build\python\lib\shutil.py", line 316, in move
18:59:01     INFO -      copy2(src, real_dst)
18:59:01     INFO -    File "c:\mozilla-build\python\lib\shutil.py", line 144, in copy2
18:59:01     INFO -      copyfile(src, dst)
18:59:01     INFO -    File "c:\mozilla-build\python\lib\shutil.py", line 96, in copyfile
18:59:01     INFO -      with open(src, 'rb') as fsrc:
18:59:01    ERROR - Return code: 1
18:59:01    ERROR - 1 not in success codes: [0]
18:59:01  WARNING - setting return code to 2
18:59:01    FATAL - Halting on failure while running ['c:\\mozilla-build\\python\\python.exe', 'mach', '--log-no-times', 'repackage', u'installer', u'--package-name', u'firefox', u'--tag', u'comm/mail/installer/windows/app.tag', u'--sfx-stub', u'comm/other-licenses/7zstub/thunderbird/7zSD.sfx', '--setupexe', u'Z:\\task_1536259302\\fetches\\setup.exe', '--package', u'Z:\\task_1536259302\\fetches\\target.zip', '--output', u'z:\\task_1536259302\\build\\outputs\\target.installer.exe']
18:59:01    FATAL - Running post_fatal callback...
18:59:01    FATAL - Exiting 2
18:59:01     INFO - [mozharness: 2018-09-06 18:59:01.356000Z] Finished repackage step (failed)

The error is due to "firefox" being hardcoded in testing/mozharness/configs/repackage/base.py.
Assignee: nobody → rob
Attachment #9007104 - Attachment description: Bug 1489355 - Windows installer build fixes r?tomprince → Bug 1489355 - Windows installer build fixes r?Callek
Comment on attachment 9007104 [details]
Bug 1489355 - Windows installer build fixes r?Callek

Justin Wood (:Callek) has approved the revision.
Attachment #9007104 - Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/integration/autoland/rev/30b97be4a9be
Windows installer build fixes r=Callek
https://hg.mozilla.org/mozilla-central/rev/30b97be4a9be
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Tom, this is a follow-up to bug 1481121 which landed on mozilla63 and was uplifted to the ESR 60. So please let me know your uplift plans for this one. I think we want to build TB 60.1 next week, so I'd have to take onto our release branch if the uplift doesn't happen quickly (and before other stuff hits m-esr60).
Flags: needinfo?(mozilla)
You'll need the fix for Bug 1488518 too. Once that has landed, I'll uplift both of them.
Flags: needinfo?(mozilla)
Tom, thanks for the uplift to mozilla-esr60:
https://hg.mozilla.org/releases/mozilla-esr60/rev/c6ea255d05af

I noticed that our TB 63 beta builds fail since it wasn't uplifted to mozilla-beta. Can you please do that together with bug 1488518 if necessary.
Flags: needinfo?(mozilla)
You need to log in before you can comment on or make changes to this bug.