Closed
Bug 1489381
Opened 6 years ago
Closed 6 years ago
Remove nsISettingsService
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(2 files)
|
2.43 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
|
5.00 KB,
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
It's unused.
|
Assignee | |
Comment 1•6 years ago
|
||
This is an old B2G leftover. The directory isn't even traversed by the build system.
Attachment #9007127 -
Flags: review?(continuation)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
Alexandre, I really don't know anything about this code... please check it carefully! :)
Attachment #9007128 -
Flags: review?(poirot.alex)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eed6acd01cc3e9c7836248bc10a18171ab8d2243
|
||
Updated•6 years ago
|
Attachment #9007127 -
Flags: review?(continuation) → review+
|
|
||
Updated•6 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 4•6 years ago
|
||
Comment on attachment 9007128 [details] [diff] [review] Remove devtools code depending on nsISettingsService Let's try a different devtools reviewer.
Attachment #9007128 -
Flags: review?(poirot.alex) → review?(gtatum)
Comment on attachment 9007128 [details] [diff] [review] Remove devtools code depending on nsISettingsService I believe Julian may be a better fit.
Attachment #9007128 -
Flags: review?(gtatum) → review?(jdescottes)
|
||
Comment 6•6 years ago
|
||
Comment on attachment 9007128 [details] [diff] [review] Remove devtools code depending on nsISettingsService Review of attachment 9007128 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! getWallpaper is no longer used and is the only consumer of getSetting, so all of this can be removed.
Attachment #9007128 -
Flags: review?(jdescottes) → review+
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/01e3c4371ccb Remove nsISettingsService.idl. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/18382d392180 Remove devtools code depending on nsISettingsService. r=jdescottes
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/01e3c4371ccb https://hg.mozilla.org/mozilla-central/rev/18382d392180
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•