Closed Bug 1489381 Opened Last year Closed Last year

Remove nsISettingsService

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(2 files)

It's unused.
This is an old B2G leftover. The directory isn't even traversed by the build
system.
Attachment #9007127 - Flags: review?(continuation)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Alexandre, I really don't know anything about this code... please check it
carefully! :)
Attachment #9007128 - Flags: review?(poirot.alex)
Attachment #9007127 - Flags: review?(continuation) → review+
Priority: -- → P3
Comment on attachment 9007128 [details] [diff] [review]
Remove devtools code depending on nsISettingsService

Let's try a different devtools reviewer.
Attachment #9007128 - Flags: review?(poirot.alex) → review?(gtatum)
Comment on attachment 9007128 [details] [diff] [review]
Remove devtools code depending on nsISettingsService

I believe Julian may be a better fit.
Attachment #9007128 - Flags: review?(gtatum) → review?(jdescottes)
Comment on attachment 9007128 [details] [diff] [review]
Remove devtools code depending on nsISettingsService

Review of attachment 9007128 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! getWallpaper is no longer used and is the only consumer of getSetting, so all of this can be removed.
Attachment #9007128 - Flags: review?(jdescottes) → review+
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01e3c4371ccb
Remove nsISettingsService.idl. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/18382d392180
Remove devtools code depending on nsISettingsService. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/01e3c4371ccb
https://hg.mozilla.org/mozilla-central/rev/18382d392180
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.