Closed Bug 1489453 Opened Last year Closed Last year

EnumSet shouldn't take 32 bits if not needed.

Categories

(Core :: MFBT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

No description provided.
This is the only reason I haven't used it before for things like
StyleSheet::State.

Change the underlying type to be the underlying enum representation by default,
but allow to override it if wanted.

Assertions should catch misuses.
Comment on attachment 9007177 [details]
EnumSet shouldn't take 32 bits if not needed.

Nathan Froyd [:froydnj] has approved the revision.
Attachment #9007177 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/6923b7cb526e
EnumSet shouldn't take 32 bits if not needed. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/6923b7cb526e
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.