Closed Bug 1489462 Opened 6 years ago Closed 6 years ago

Avoid writing past the logical length of a string in Oculus library loader

Categories

(Core :: WebVR, enhancement)

Product:
Core
Component:
WebVR
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(1 file)

Bug 1489462 - Avoid writing past the logical length of a string in Oculus library loader.
46 bytes, text/x-phabricator-request
kip
: review+
Details | Review 
* Avoid writing past an XPCOM string's length using BeginWriting().
 * Instead of having a constant for max path length, query the
   Windows API for the length it wants.
 * Avoid using AppendPrintf for mere concatenation using arguments
   that might contain non-ASCII.

MozReview-Commit-ID: 9m7xOHRTB35
Comment on attachment 9007421 [details]
Bug 1489462 - Avoid writing past the logical length of a string in Oculus library loader.

:kip (Kearwood Gilbert) has approved the revision.
Attachment #9007421 - Flags: review+
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3dbc855f18d5
Avoid writing past the logical length of a string in Oculus library loader. r=kip
https://hg.mozilla.org/mozilla-central/rev/3dbc855f18d5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: