1489462 - Avoid writing past the logical length of a string in Oculus library loader

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[Henri Sivonen (:hsivonen) (not reading bugmail until 2026-07-27)]

See https://groups.google.com/d/msg/mozilla.dev.platform/amMU6GKRIb4/NR24WLA4CwAJ

Comment 1

[Henri Sivonen (:hsivonen) (not reading bugmail until 2026-07-27)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cde900728bbb03785ab7a9d7535487c3ccc5ae4a

Comment 2

[Henri Sivonen (:hsivonen) (not reading bugmail until 2026-07-27)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ca3a7aa7ee0c0e89caa447686a4d6cd8c3db96e

Comment 3

[Henri Sivonen (:hsivonen) (not reading bugmail until 2026-07-27)]

Attachment: Bug 1489462 - Avoid writing past the logical length of a string in Oculus library loader.

* Avoid writing past an XPCOM string's length using BeginWriting().
 * Instead of having a constant for max path length, query the
   Windows API for the length it wants.
 * Avoid using AppendPrintf for mere concatenation using arguments
   that might contain non-ASCII.

MozReview-Commit-ID: 9m7xOHRTB35

Comment 4

[:kip (Kearwood Gilbert)]

Comment on attachment 9007421 [details]
Bug 1489462 - Avoid writing past the logical length of a string in Oculus library loader.

:kip (Kearwood Gilbert) has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dbc855f18d5
Avoid writing past the logical length of a string in Oculus library loader. r=kip

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/3dbc855f18d5