Closed Bug 1489476 Opened 7 years ago Closed 7 years ago

Users consent to set custom search as default is not displayed for extension update

Categories

(Firefox :: Search, defect)

62 Branch
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: deepak.gupta, Unassigned)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36 Steps to reproduce: I have a webExtension that offers custom search via newtab for users. Since now settings_override API is available that allows to set custom search in address bar as default. I am trying to update my users to opt in with extension update to set my search engine as default. Steps: 1. User already have Newtab Search extension 2. Updated extension to use settings_override API and set my search as default 3. Update was successful and my Search engine was added to list of search engine available 4. No consent was displayed to user for permission update to set search engine as default. Actual results: Extension was updated with new search engine but permission update dialogue was not shown to user. Expected results: Users should be prompted with update in permission dialogue as extension is requesting new permission for user to update the default search.
Product: Firefox → WebExtensions
Mike, I think you said this done this way by design?
Flags: needinfo?(mozilla)
Yes, this is by design, otherwise, extensions could simply change their search engine data and keep asking to add an engine. We're investigating a better way to do search permissions, but this is not happening very soon.
Flags: needinfo?(mozilla)
Closing per comment 2
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Mike, I think this would be true in case user has already been presented with the permission (so that extensions could not keep asking to add an engine) but for extensions that are adding it as a new permission for the first time, users should be given an option to accept/reject the change.
We're in the process of looking at WebExtensions, search and search policy. We'll probably have some updates soon.
Thanks! It will be helpful if you can link me where the announcement policy changes will be published.
When it happens, it will be the addons blog. https://blog.mozilla.org/addons/
Component: Untriaged → Search
Product: WebExtensions → Firefox
You need to log in before you can comment on or make changes to this bug.