Closed Bug 1489495 Opened Last year Closed Last year

Synced tabs sidebar instructions should have higher contrast when themed

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 64
Tracking Status
firefox63 --- verified
firefox64 --- verified

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → ntim.bugs
Comment on attachment 9007206 [details]
Bug 1489495 - Fix synced tabs sidebar instructions text color with WebExtension themes. r?dao

Dão Gottwald [::dao] has approved the revision.
Attachment #9007206 - Flags: review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/24f9821c4221
Fix synced tabs sidebar instructions text color with WebExtension themes. r=dao
Comment on attachment 9007206 [details]
Bug 1489495 - Fix synced tabs sidebar instructions text color with WebExtension themes. r?dao

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1418602
[User impact if declined]: WebExtension themes theming the sidebar will have a low contrast description
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: see comment 0
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: css only 
[String changes made/needed]:
Attachment #9007206 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/24f9821c4221
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Can it be verified in Nightly before uplifting to beta? Thanks
Flags: qe-verify+
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:64.0) Gecko/20100101 Firefox/64.0
Build ID: 20180907100116

Verified as fixed on the latest Nightly build (64.0a1 2018-09-10).
Comment on attachment 9007206 [details]
Bug 1489495 - Fix synced tabs sidebar instructions text color with WebExtension themes. r?dao

Small CSS only fix, verified on Nightly. Uplift approved for 63 beta 6.
Attachment #9007206 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180913141435

This issue is still reproducible on the latest Beta build (63.0b6) and it was tested on MacOS and also on Windows. 


Could you please take a look at the commit and check if everything is ok there?
Flags: needinfo?(ntim.bugs)
(In reply to Cristian Craciun from comment #10)
> User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:63.0)
> Gecko/20100101 Firefox/63.0
> Build ID: 20180913141435
> 
> This issue is still reproducible on the latest Beta build (63.0b6) and it
> was tested on MacOS and also on Windows. 
> 
> 
> Could you please take a look at the commit and check if everything is ok
> there?

The difference with the dark theme enabled is not that emphasized. 

The difference is more pronounced with theme like this one: https://addons.mozilla.org/en-US/firefox/addon/arc-dark-theme-we/

Can you test if the situation has improved for the theme I've linked above ?

Thank you.
Flags: needinfo?(ntim.bugs) → needinfo?(george.craciun)
Indeed, using the theme mentioned above ("Arc Dark"), the fix is clearer. This issue is fixed also on the Beta build (63.0b6). 

The theme used for testing this issue was the "Dark" standard theme. I was confused by the background; instead of changing it to a black color (like it does on Nightly), it remains the same color (white) same as the default theme. Should I log another bug regarding this particular theme?
Flags: needinfo?(george.craciun) → needinfo?(ntim.bugs)
(In reply to Cristian Craciun from comment #12)
> The theme used for testing this issue was the "Dark" standard theme. I was
> confused by the background; instead of changing it to a black color (like it
> does on Nightly), it remains the same color (white) same as the default
> theme. Should I log another bug regarding this particular theme?

This is intentional, bug 1385518 only landed in Firefox 64 (to give more time to catch/fix regressions regarding the dark theme sidebars).
Flags: needinfo?(ntim.bugs)
Based on the Comment 13 this bug is closed as verified fixed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.